Code

Specification glitches#466

Code

Merged

OlivierBBB merged 124 commits intomasterConsensys/linea-constraints:masterfrom 465-specification-glitchesConsensys/linea-constraints:465-specification-glitchesCopy head branch name to clipboardOct 26, 2024

+1,803-1,879

Commits

Commits on Oct 20, 2024

• fix: removed duplicate hub-stamp-constancies

  OlivierBBB

  committed
  1b6e1ae

  Copy full SHA for 1b6e1ae

• fix: removed duplicate of transaction-constancy of HUB_STAMP_TRANSACTION_END

  OlivierBBB

  committed
  bbe1bda

  Copy full SHA for bbe1bda

• fix: naming of constraints

  OlivierBBB

  committed
  8e29267

  Copy full SHA for 8e29267

• fix: formatting

  OlivierBBB

  committed
  02868b6

  Copy full SHA for 02868b6

• fix: removed HASH_INFO_STAMP from the constraints

  OlivierBBB

  committed
  f5a06e6

  Copy full SHA for f5a06e6

• ras: spacing

  OlivierBBB

  committed
  56dd04c

  Copy full SHA for 56dd04c

• fix: included (vacuously true precondition) for MXP call for RETURN instruction

  OlivierBBB

  committed
  5d6f081

  Copy full SHA for 5d6f081

• fix: formatting

  OlivierBBB

  committed
  0e69267

  Copy full SHA for 0e69267

• fix: formatting and naming of INVALID instruction family

  OlivierBBB

  committed
  935a970

  Copy full SHA for 935a970

• fix: setting NSR for INVALID instruction family

  OlivierBBB

  committed
  9d19111

  Copy full SHA for 9d19111

• fix: removed deprecated context functions file

  Show description for f376080
  OlivierBBB

  committed
  f376080

  Copy full SHA for f376080

• fix: BUG: added missing OPCX from the weighted_sum + order of exception flags

  OlivierBBB

  committed
  ee57e5b

  Copy full SHA for ee57e5b

Commits on Oct 21, 2024

• fix: HUB into GAS lookup was missing a column rel. the spec

  OlivierBBB

  committed
  5643e69

  Copy full SHA for 5643e69

• fix: "account-turn-on-warmth" added to "account-initiate-for-deployment"

  OlivierBBB

  committed
  75a04ae

  Copy full SHA for 75a04ae

• fix: "account-initiate-for-deployment" given correct CODE_SIZE_NEW

  OlivierBBB

  committed
  1482d25

  Copy full SHA for 1482d25

• fix: 'account-deletion' constraint

  OlivierBBB

  committed
  45540d5

  Copy full SHA for 45540d5

• fix: added "account-fresh-new-deployment-number-and-status" constraint system

  OlivierBBB

  committed
  f9774e8

  Copy full SHA for f9774e8

• ras: order of exception flags

  OlivierBBB

  committed
  b6892ae

  Copy full SHA for b6892ae

• fix: shorthands + constants + naming conventions

  OlivierBBB

  committed
  45d0cdd

  Copy full SHA for 45d0cdd

• fix: MACHINESTATE results are written only if no exception occurred

  OlivierBBB

  committed
  1ab9c68

  Copy full SHA for 1ab9c68

• fix: ROW_OFFSET -> ROFF for COPY instruction family

  OlivierBBB

  committed
  24bed18

  Copy full SHA for 24bed18

• fix: added shorthands to the CONTEXT instruction family

  OlivierBBB

  committed
  2cd3d37

  Copy full SHA for 2cd3d37

• fix: using ROFF

  OlivierBBB

  committed
  2fdf952

  Copy full SHA for 2fdf952

• fix: admissible exceptions

  OlivierBBB

  committed
  4f61160

  Copy full SHA for 4f61160

• fix: shorthands for value setting + "CMC = 0" -> "XAHOY = 0" precondition

  OlivierBBB

  committed
  4e6cd21

  Copy full SHA for 4e6cd21

• ras: naming + spacing

  OlivierBBB

  committed
  4e58c55

  Copy full SHA for 4e58c55

• fix: HUB_STAMP vanishing during padding

  Show description for 157443e
  OlivierBBB

  committed
  157443e

  Copy full SHA for 157443e

• ras: formatting & spacing

  OlivierBBB

  committed
  5c73c00

  Copy full SHA for 5c73c00

• fix: fixed incorrect (prev ...) + follow order of spec

  OlivierBBB

  committed
  3710ce1

  Copy full SHA for 3710ce1

• fix: typo

  Show description for 1e5a55d
  OlivierBBB

  committed
  1e5a55d

  Copy full SHA for 1e5a55d

• fix: STATUS --> NUMBER when imposing monotony on DEPLOYMENT_NUMBER

  OlivierBBB

  committed
  02ddfac

  Copy full SHA for 02ddfac

• fix: mix up's with CTXT/SPOT and FIRST/AGAIN

  OlivierBBB

  committed
  521ead4

  Copy full SHA for 521ead4

• fix: formatting

  OlivierBBB

  committed
  77c2609

  Copy full SHA for 77c2609

• fix: typo where FINAL should have been FIRST

  OlivierBBB

  committed
  f649d3a

  Copy full SHA for f649d3a

• fix: stack consistency constraint was missing a HEIGHT != 0 precondition

  OlivierBBB

  committed
  780b21d

  Copy full SHA for 780b21d

• fix: formatting

  OlivierBBB

  committed
  d9c21bc

  Copy full SHA for d9c21bc

• ras

  OlivierBBB

  committed
  7c57e6d

  Copy full SHA for 7c57e6d

• fix: extract "lead-log" from EXP and not OOB

  OlivierBBB

  committed
  187502f

  Copy full SHA for 187502f

• fix: provide the OOB's MODEXP_PRICING instruction with the correct "full" log

  OlivierBBB

  committed
  501d5ef

  Copy full SHA for 501d5ef

• fix: formatting and spacing

  OlivierBBB

  committed
  7b8756f

  Copy full SHA for 7b8756f

• fix: there is only one case of "modulus extraction" for MODEXP calls

  OlivierBBB

  committed
  580dc7d

  Copy full SHA for 580dc7d

• ras: formatting

  OlivierBBB

  committed
  4259f30

  Copy full SHA for 4259f30

• fix: inversion of caller/callee deployment number among the CALL instructions

  OlivierBBB

  committed
  ee91cb8

  Copy full SHA for ee91cb8

• fix: missing "sameMarkedForSelfDestructFlag" in unaborted CREATE's

  OlivierBBB

  committed
  6fe4319

  Copy full SHA for 6fe4319

• ras

  OlivierBBB

  committed
  5ede0b0

  Copy full SHA for 5ede0b0

• fix: ugly hack ... will it even work ?

  OlivierBBB

  committed
  4796593

  Copy full SHA for 4796593

• fix: make it compile

  Show description for 664be46
  OlivierBBB

  committed
  664be46

  Copy full SHA for 664be46

• fix: trimming address with function rather than by hand

  Show description for 163891e
  OlivierBBB

  committed
  163891e

  Copy full SHA for 163891e

• fix: formatting and naming conventions

  OlivierBBB

  committed
  2f6f7b1

  Copy full SHA for 2f6f7b1

• fix: missing precondition in "perpetuating-address-and-dep-num-for-storage-rows"

  OlivierBBB

  committed
  68ca79d

  Copy full SHA for 68ca79d

• ras: formatting

  OlivierBBB

  committed
  a81ab09

  Copy full SHA for a81ab09

• ras: formatting and spaces

  OlivierBBB

  committed
  289c5d3

  Copy full SHA for 289c5d3

• fix: trimming now in case of PURE TRANSFER's (rather than TRIVIAL DEPLOYMENTS)

  OlivierBBB

  committed
  dbc2aa7

  Copy full SHA for dbc2aa7

• fix: TX_SKIP was setting DEPLOYMENT_STATUS to 1 in case of a trivial deployment

  OlivierBBB

  committed
  f68c7bb

  Copy full SHA for f68c7bb

• fix: STORAGE instruction with OOGX now uses stack/OOGX as a precondition

  OlivierBBB

  committed
  3ffe96d

  Copy full SHA for 3ffe96d

• fix: (set-MMU-inst---blake ...) was missing the tgt_id argument

  OlivierBBB

  committed
  4d442f1

  Copy full SHA for 4d442f1

• fix: passing arguments to the only invocation of "set-MMU-instruction---blake"

  OlivierBBB

  committed
  a7b0a5d

  Copy full SHA for a7b0a5d

• fix: formatting

  OlivierBBB

  committed
  ede7c9c

  Copy full SHA for ede7c9c

• fix: EXTCODECOPY relatd row offset constants mix-up

  OlivierBBB

  committed
  1953955

  Copy full SHA for 1953955

• fix: reference-size now references the code size for EXTCODECOPY

  OlivierBBB

  committed
  57b070e

  Copy full SHA for 57b070e

• ras

  OlivierBBB

  committed
  85b7d6c

  Copy full SHA for 85b7d6c

• fix: compare DEPLOYMENT_NUMBER's to same type of number

  OlivierBBB

  committed
  7437528

  Copy full SHA for 7437528

• fix: setting stack/MXPX in terms of mxp/MXPX

  OlivierBBB

  committed
  04849c9

  Copy full SHA for 04849c9

• fix: NSR for CODECOPY now depends on XAHOY rather than stack/RDCX

  OlivierBBB

  committed
  cd9228b

  Copy full SHA for cd9228b

• ras: spacing

  OlivierBBB

  committed
  766096d

  Copy full SHA for 766096d

• ras: formatting ...

  OlivierBBB

  committed
  1ee340f

  Copy full SHA for 1ee340f

Commits on Oct 22, 2024

• fix: naming + formatting

  OlivierBBB

  committed
  c8f7fd7

  Copy full SHA for c8f7fd7

• fix: setting MISC flags only if no staticContextViolationException

  OlivierBBB

  committed
  753a965

  Copy full SHA for 753a965

• fix: setting MXP data only if no staticContextViolationException

  OlivierBBB

  committed
  6655e87

  Copy full SHA for 6655e87

• fix: final row (if exceptional) is a CONTEXT row

  OlivierBBB

  committed
  f74fdd4

  Copy full SHA for f74fdd4

• fix: corrected offset where to read context/IS_STATIC

  OlivierBBB

  committed
  4eb8704

  Copy full SHA for 4eb8704

• ras: naming + formatting

  OlivierBBB

  committed
  c15835f

  Copy full SHA for c15835f

• fix: added (surprising) call to TRM for createe address

  Show description for a90cc50
  OlivierBBB

  committed
  a90cc50

  Copy full SHA for a90cc50

• ras: formatting

  OlivierBBB

  committed
  449f2e2

  Copy full SHA for 449f2e2

• fix: smc failure or success measured by callee SELF_REVERTS

  OlivierBBB

  committed
  3b49a6f

  Copy full SHA for 3b49a6f

• fix: mix up in address HI/LO parts

  OlivierBBB

  committed
  5c4eee2

  Copy full SHA for 5c4eee2

• fix: well_formed_data hinges on misc/MMU_SUCCESS_BIT, not its negation

  OlivierBBB

  committed
  877889e

  Copy full SHA for 877889e

• fix: moved OOB shorthands to the top in call/precompiles/common/generalities

  OlivierBBB

  committed
  0d7e553

  Copy full SHA for 0d7e553

• fix: fixed debug constraint

  OlivierBBB

  committed
  9ad9dc3

  Copy full SHA for 9ad9dc3

• ras: formatting

  OlivierBBB

  committed
  62392aa

  Copy full SHA for 62392aa

• ras

  OlivierBBB

  committed
  0ea40e4

  Copy full SHA for 0ea40e4

• ras: using the STACK_ROW row offset a bit more

  OlivierBBB

  committed
  7caaa58

  Copy full SHA for 7caaa58

• ras: renaming + formatting

  OlivierBBB

  committed
  ff83fd7

  Copy full SHA for ff83fd7

• fix: moved "provide-return-data" of REVERT

  Show description for 12e4114
  OlivierBBB

  committed
  12e4114

  Copy full SHA for 12e4114

• ras: naming + formatting for SELFDESTRUCT's

  OlivierBBB

  committed
  49c8600

  Copy full SHA for 49c8600

• fix: major bug fix for account deletion of SELFDESTRUCT

  Show description for fe999b4
  OlivierBBB

  committed
  fe999b4

  Copy full SHA for fe999b4

• ras: spacing

  OlivierBBB

  committed
  4186e72

  Copy full SHA for 4186e72

• fix: selector of HUB -> ROMLEX lookup

  Show description for 26ca011
  OlivierBBB

  committed
  26ca011

  Copy full SHA for 26ca011

• ras: spacing and naming

  OlivierBBB

  committed
  dc5e471

  Copy full SHA for dc5e471

• fix: constraint enforcing that the ROMLEX lookup requires nonzero code size

  OlivierBBB

  committed
  3aca051

  Copy full SHA for 3aca051

• ras: spacing and formatting

  OlivierBBB

  committed
  17fb344

  Copy full SHA for 17fb344

• ras: spacing and formatting ... again

  OlivierBBB

  committed
  a4e7ccc

  Copy full SHA for a4e7ccc

• ras: spacing and formatting

  OlivierBBB

  committed
  6851d04

  Copy full SHA for 6851d04

• ras

  OlivierBBB

  committed
  13d8380

  Copy full SHA for 13d8380

• ras

  OlivierBBB

  committed
  1f86a6b

  Copy full SHA for 1f86a6b

• ras

  OlivierBBB

  committed
  d0cae2b

  Copy full SHA for d0cae2b

• fix: typo

  OlivierBBB

  committed
  b7ef8ba

  Copy full SHA for b7ef8ba

• fix: using shorthands in STORAGE instruction family constraints

  OlivierBBB

  committed
  56f2ba5

  Copy full SHA for 56f2ba5

• fix: OOB inst "blake" now "blake-params" in compliance with spec

  OlivierBBB

  committed
  02e809e

  Copy full SHA for 02e809e

• fix: the TRM's PBIT now called PLATEAU_BIT (and alias introduced)

  OlivierBBB

  committed
  7fc732f

  Copy full SHA for 7fc732f

• fix: uncommented lookups and replaced .lisp with .lispX instead

  Show description for 6d2a219
  OlivierBBB

  committed
  6d2a219

  Copy full SHA for 6d2a219

Commits on Oct 23, 2024

• ras

  OlivierBBB

  committed
  9c370c4

  Copy full SHA for 9c370c4

• fix: made explicit trimming constraints debug in favour of "account-trim-address" function call

  OlivierBBB

  committed
  9474f99

  Copy full SHA for 9474f99

Commits on Oct 24, 2024

• fix: setting PC_NEW only if unexceptional JUMPI instruction

  OlivierBBB

  committed
  8a7353a

  Copy full SHA for 8a7353a

• fix: added (useless, but standard) extra check into the RETURN's standard precondition

  OlivierBBB

  committed
  ee4eed1

  Copy full SHA for ee4eed1

Commits on Oct 25, 2024

• Merge branch 'master' into 465-specification-glitches

  OlivierBBB

  committed
  2131d9b

  Copy full SHA for 2131d9b

• fix: old constant

  OlivierBBB

  committed
  53c2673

  Copy full SHA for 53c2673

Commits on Oct 26, 2024

• ras: naming

  OlivierBBB

  committed
  7cced1a

  Copy full SHA for 7cced1a

• ras: naming + formatting for KEC instruction family

  OlivierBBB

  committed
  3f08775

  Copy full SHA for 3f08775

• ras: KEC instruction family naming + formatting

  OlivierBBB

  committed
  64b2aed

  Copy full SHA for 64b2aed

• ras

  OlivierBBB

  committed
  f854e89

  Copy full SHA for f854e89

• fix: added CODECOPY debug constraints

  OlivierBBB

  committed
  f3c2e9f

  Copy full SHA for f3c2e9f

• ras: spacing in CODECOPY specificities

  OlivierBBB

  committed
  5a64b49

  Copy full SHA for 5a64b49

• ras

  OlivierBBB

  committed
  8672364

  Copy full SHA for 8672364

• ras: renaming + spacing

  OlivierBBB

  committed
  c5feca2

  Copy full SHA for c5feca2

• fix: allowable exceptoins for STACK_RAM instruction family

  OlivierBBB

  committed
  7fc8c9a

  Copy full SHA for 7fc8c9a

• ras: naming mostly

  OlivierBBB

  committed
  269df52

  Copy full SHA for 269df52

• fix: allowable exceptions for STACK_RAM

  OlivierBBB

  committed
  311f244

  Copy full SHA for 311f244

• fix: using and defining shorthands for STACK_RAM instructions

  OlivierBBB

  committed
  16b7898

  Copy full SHA for 16b7898

• fix: moved the setting of CALLDATALOAD's context row after MISC row shenanigans

  OlivierBBB

  committed
  830b1f1

  Copy full SHA for 830b1f1

• fix: using (stack-ram---misc-XXX-flag) shorthands

  OlivierBBB

  committed
  d1802a2

  Copy full SHA for d1802a2

• ras

  OlivierBBB

  committed
  e347dee

  Copy full SHA for e347dee

• ras

  OlivierBBB

  committed
  065a935

  Copy full SHA for 065a935

• ras

  OlivierBBB

  committed
  d3dcae3

  Copy full SHA for d3dcae3