Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: type of SHB_k_XX columns #393

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

OlivierBBB
Copy link
Collaborator

No description provided.

@OlivierBBB OlivierBBB self-assigned this Sep 21, 2024
@OlivierBBB OlivierBBB linked an issue Sep 21, 2024 that may be closed by this pull request
(SHB_6_HI :byte)
(SHB_6_LO :byte)
(SHB_7_HI :byte)
(SHB_7_LO :byte))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The switch from :i128 to :byte (not :byte@prove BTW) is the only change that matters. Everything else is just formatting (uniform spaces)

Copy link
Collaborator

@letypequividelespoubelles letypequividelespoubelles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do the corresponding tracer PR with updated Trace.java once merged please ?

@OlivierBBB OlivierBBB merged commit 760fb57 into master Sep 23, 2024
2 checks passed
@OlivierBBB OlivierBBB deleted the 392-veridise-wrong-type-for-shb-columns branch September 23, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type for SHB columns
2 participants