Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of MMIO update #386

Merged
merged 10 commits into from
Sep 23, 2024
Merged

Conversation

OlivierBBB
Copy link
Collaborator

No description provided.

@OlivierBBB OlivierBBB linked an issue Sep 19, 2024 that may be closed by this pull request
@OlivierBBB OlivierBBB self-assigned this Sep 19, 2024
@letypequividelespoubelles letypequividelespoubelles linked an issue Sep 20, 2024 that may be closed by this pull request
Copy link
Collaborator

@letypequividelespoubelles letypequividelespoubelles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -82,7 +82,10 @@ LOG_INFO := loginfo

MMU := mmu

MMIO := mmio/columns.lisp #TODO enable the MMIO constraint and lookup
MMIO := mmio/columns.lisp
#TODO enable the MMIO constraint and lookup
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you change the std way ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean why did I move the comment ? I don't know

[ACC 1]
[POW_256 1]
SBO
TBO
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addition of TBO

accumulator
pow
source_marker
target_marker
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addition of target_marker

counter)
(begin (plateau bit1 source_marker counter)
(plateau bit2 (+ source_marker size) counter)
(plateau bit3 (+ target_marker size) counter)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usage here

pow1
pow2
source1_marker
target_marker
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addition of target_marker

[POW_256 1]
[POW_256 2]
SBO
TBO
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBO

(if-eq counter LLARGEMO
(eq! target
(+ (* accumulator1 pow1) (* accumulator2 pow2))))))
(plateau bit4 (+ target_marker size) counter)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target_marker

@OlivierBBB OlivierBBB merged commit 5c34dd8 into master Sep 23, 2024
2 checks passed
@OlivierBBB OlivierBBB deleted the 385-implementation-of-mmio-update branch September 23, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of MMIO update fix ramToLimbSingleSource doesn't read TBO
2 participants