Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mmu): add missing constraint #324

Merged
merged 3 commits into from
Sep 11, 2024
Merged

fix(mmu): add missing constraint #324

merged 3 commits into from
Sep 11, 2024

Conversation

letypequividelespoubelles
Copy link
Collaborator

No description provided.

@letypequividelespoubelles
fix(mmu): add missing constraint
013d279 
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
@letypequividelespoubelles letypequividelespoubelles linked an issue Sep 6, 2024 that may be closed by this pull request
Missing/Incorect MMU constraints #323
Closed
@letypequividelespoubelles
fix(mmu): add missing constraint for any_to_ram_with_padding
e26fbc9 
Signed-off-by: Francois Bojarski <francois.bojarski@consensys.net>
lorenzogentile404
lorenzogentile404 reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@lorenzogentile404 lorenzogentile404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you paste the link to the Veridise issue?

@letypequividelespoubelles
Copy link
Collaborator Author

Can you paste the link to the Veridise issue?
The link is in the issue already

lorenzogentile404
lorenzogentile404 reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@lorenzogentile404 lorenzogentile404 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot find where Veridise issue 4a is addressed, the rest LGTM.

@letypequividelespoubelles
Copy link
Collaborator Author

I cannot find where Veridise issue 4a is addressed, the rest LGTM.

Nice catch. It's because it's a trash constraint, I left a comment in the Veridise audit

@letypequividelespoubelles letypequividelespoubelles merged commit bea9ff5 into master Sep 11, 2024
2 checks passed
@letypequividelespoubelles letypequividelespoubelles deleted the 323-missing-incorect-mmu-constraints branch September 11, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzogentile404 lorenzogentile404 lorenzogentile404 approved these changes

@OlivierBBB OlivierBBB Awaiting requested review from OlivierBBB

Assignees

@letypequividelespoubelles letypequividelespoubelles

Labels
veridise audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing/Incorect MMU constraints
3 participants
@letypequividelespoubelles @lorenzogentile404 @OlivierBBB