Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hub constraints debugging #224

Merged
merged 51 commits into from
Aug 5, 2024
Merged

Hub constraints debugging #224

merged 51 commits into from
Aug 5, 2024

Conversation

OlivierBBB
Copy link
Collaborator

No description provided.

@OlivierBBB OlivierBBB linked an issue Jun 1, 2024 that may be closed by this pull request
HUB constraints debugging #222
Closed
@letypequividelespoubelles letypequividelespoubelles mentioned this pull request Jun 5, 2024
Closed
@letypequividelespoubelles letypequividelespoubelles force-pushed the fix/issue-222/HUB-constraints-debugging branch from c4aed4b to 73cb482 Compare June 5, 2024 05:22
@letypequividelespoubelles letypequividelespoubelles force-pushed the fix/issue-222/HUB-constraints-debugging branch from 15ac2bd to 4e868ac Compare June 14, 2024 11:42
letypequividelespoubelles and others added 26 commits June 28, 2024 15:21
@letypequividelespoubelles
style(rom): view opcode in rom as opcode
195637f
@OlivierBBB @letypequividelespoubelles
ras
4c86d35
@OlivierBBB @letypequividelespoubelles
removed obsolete columns from the instruction decoder
9b94f82
@OlivierBBB @letypequividelespoubelles
uniformize some constraint names
586d052
@OlivierBBB @letypequividelespoubelles
fixed misc module flags of EXP instruction
7034c4d
@OlivierBBB @letypequividelespoubelles
fix: hub-into-wcp lookup
a650b5f
@OlivierBBB @letypequividelespoubelles
another lookup with the wrong indices ...
0056efa
@OlivierBBB @letypequividelespoubelles
same failing lookup issue
e455045
@letypequividelespoubelles
fix: lex ordre in makefile + add lookups
db663bf
@letypequividelespoubelles
style(trm): nothing
6a66d57
@OlivierBBB @letypequividelespoubelles
revert-dom-sub-stamps ==> revert-with-current-dom-sub-stamps
91d3760
@OlivierBBB @letypequividelespoubelles
DOM-SUB stamp macros
90aae65
@OlivierBBB @letypequividelespoubelles
hub constants
d0ef2f4 
moved the HUB constants into a dedicated file
@OlivierBBB @letypequividelespoubelles
loobeans must go ...
2cf4a16
@OlivierBBB @letypequividelespoubelles
fix(RETURN): typo in the preconditions for the deployment case
a9e255e
@OlivierBBB @letypequividelespoubelles
fix(STOP): wrong preconditions for STOP'ing during a deployment
9d98edb
@letypequividelespoubelles
fix(hub): fix tx-skip-precondition
391adf7
@OlivierBBB @letypequividelespoubelles
undoing what I just did, this column is useful ^^
aedc042 
we use it to compute the rate at which the COINBASE pockets fees at
transaction finalization.
@OlivierBBB @letypequividelespoubelles
fixed TX_SKIP coinbase fee reward constraints
58d1486 
previously
- was using deprecated MAX_PRIORITY_FEE_PER_GAS column
- wasn't distinguishing between TYPE2 transactions and other types
both issues are fixed now
@OlivierBBB @letypequividelespoubelles
UNCONSTRAINED_FIRST/FINAL columns
1ecde92
@letypequividelespoubelles
feat: enable hub oob lookup
5d45e6d
@letypequividelespoubelles
feat: reenable lookup rlptxn -> hub
c2ad40d
@letypequividelespoubelles
fix: fix rlptxn <-> hub lookups, column inversion
bcfcecd
@OlivierBBB @letypequividelespoubelles
storage instruction constraint renaming
4c779b9
@OlivierBBB @letypequividelespoubelles
ras
8665f52
@letypequividelespoubelles
fix(txndata): shorthand not define, use the column
a3f37d6
@letypequividelespoubelles letypequividelespoubelles force-pushed the fix/issue-222/HUB-constraints-debugging branch from c0ec1e1 to 3106c36 Compare June 28, 2024 09:52
letypequividelespoubelles and others added 19 commits June 28, 2024 16:27
@letypequividelespoubelles
disabling almost all HUB constraint
bd2f695
@letypequividelespoubelles
only lookups in constraint
255677b
@OlivierBBB
MODEXP implementation done
430077f
@OlivierBBB
fix to make it compile again
b40be86
@letypequividelespoubelles
reenable HUB constraint
60bde00
@letypequividelespoubelles
reenable lookups from hub
2001467
@letypequividelespoubelles
re fix log NSR typo
74f2885
@OlivierBBB
fix(machine-state): fixed machine-state-instruction---setting-miscell…
993e90a 
…aneous-row constraint + ras
@OlivierBBB
ras
e175b4e
@lorenzogentile404
fix(hub): hub into rom jump destination vetting lookup
29b10da
@letypequividelespoubelles
fix(hub): acc/rlpaddr/recipe typing
03e1cad
@letypequividelespoubelles
fix(hub): typo in extcodecopy
66cf5cf
@OlivierBBB
Merge branch 'master' into fix/issue-222/HUB-constraints-debugging
30b1df2
@OlivierBBB
fix: make it compile again
980397e
@letypequividelespoubelles
fix(return): typo, forget PEEK in the guard
7c44e4b
@OlivierBBB
feat(ec precompiles): implementation of ECADD, ECMUL and ECPAIRING
685f3d4
@OlivierBBB
ras
a759b56
@OlivierBBB
feat(blake): BLAKE2f implementation
f93361f
@OlivierBBB
fix(compile): made it compile again
3842052
letypequividelespoubelles
letypequividelespoubelles approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@letypequividelespoubelles letypequividelespoubelles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@letypequividelespoubelles
Copy link
Collaborator

@OlivierBBB Do we want to have all modules in the Makefile?
Or we keep disabled HUB & MMIO, because not yet fully debugged ?

@OlivierBBB
Copy link
Collaborator Author

@letypequividelespoubelles that's a good question, and it's not the first time we face this type of question of "when should we merge x into main." It's also a question for @powerslider since he would know what we expose to other repos.

@OlivierBBB OlivierBBB merged commit 75de926 into master Aug 5, 2024
2 checks passed
@OlivierBBB OlivierBBB deleted the fix/issue-222/HUB-constraints-debugging branch August 5, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@letypequividelespoubelles letypequividelespoubelles letypequividelespoubelles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HUB constraints debugging
3 participants
@OlivierBBB @letypequividelespoubelles @lorenzogentile404