RIPSHA module Corset implementation #114
Conversation
Makefile
Outdated
| @@ -19,10 +19,10 @@ BIN := bin | |||
| CONSTANTS := constants/constants.lisp | |||
|
|
|||
| EC_DATA := ec_data/columns.lisp \ | |||
There was a problem hiding this comment.
just EC_DATA := ec_data and put the lookups in a lookups folder, as for other modules.
There was a problem hiding this comment.
Done. The new folder structure is
ec_data/
├── columns.lisp
├── constraints.lisp
└── lookups
├── ecdata_into_ext.lisp
└── ecdata_into_wcp.lisp
Makefile
Outdated
| ec_data/constraints.lisp \ | ||
| ec_data/ecdata_into_ext.lisp \ | ||
| ec_data/ecdata_into_wcp.lisp \ | ||
| ec_data/hub_into_ecdata.lisp \ |
There was a problem hiding this comment.
isn't the lookup from the hub supposed to be in the hub folder ?
There was a problem hiding this comment.
No, that's old stuff from almost a year ago. I deleted it.
Makefile
Outdated
| @@ -43,28 +43,33 @@ MXP := mxp/columns.lisp \ | |||
|
|
|||
| PUB_DATA := $(shell find pub/ -iname '*.lisp') | |||
|
|
|||
| RIPSHA := ripsha/columns.lisp \ | |||
| ripsha/constraints.lisp | |||
|
|
|||
| RLP_ADDR := rlpAddr | |||
|
|
|||
| RLP_TXN := rlp_txn | |||
|
|
|||
| RLP_TXRCPT := rlp_txrcpt | |||
|
|
|||
| ROM := rom/columns.lisp \ | |||
Makefile
Outdated
| @@ -43,28 +43,33 @@ MXP := mxp/columns.lisp \ | |||
|
|
|||
| PUB_DATA := $(shell find pub/ -iname '*.lisp') | |||
|
|
|||
| RIPSHA := ripsha/columns.lisp \ | |||
|
|
||
| SHIFT := shf | ||
|
|
||
| STACK := hub/columns.lisp \ | ||
| hub/constraints.lisp | ||
| hub/constraints.lisp | ||
|
|
||
| STP := stp/columns.lisp stp/constraints.lisp \ |
There was a problem hiding this comment.
hub will soon be deleted in favour of hub_v2 so I'm not touching that one.
Makefile
Outdated
| rom/constraints.lisp \ | ||
| rom/rom_into_instructionDecoder.lisp | ||
| rom/constraints.lisp \ | ||
| rom/rom_into_instructionDecoder.lisp | ||
|
|
||
| ROM_LEX := romLex/columns.lisp romLex/constraints.lisp \ |
| @@ -177,13 +177,19 @@ | |||
| ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; BLAKE MODEXP MODULE ;; | |||
| ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;; | |||
| ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; | |||
| MODEXP_PHASE_BASE 1 | |||
There was a problem hiding this comment.
I personnaly prefer to have the name of the main module at the begining of the name of the constant, as it is shared with all other module, much easier to read
There was a problem hiding this comment.
and will be consistent with the naming of all other module's constants
There was a problem hiding this comment.
It's not a module name, it's a PHASE number. There are for instance PHASE numbers and INSTRUCTIONS e.g.
[[EXP_INST_expLog]]
[[MMU_INST_mload]]
[[OOB_INST_modexp_lead_log]]
[[PHASE_modexp_result]]etc ...
No description provided.