Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #951 plonk verifier checks witness length #952

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix: #951 plonk verifier checks witness length #952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions backend/plonk/bls12-377/verify.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions backend/plonk/bls12-381/verify.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions backend/plonk/bls24-315/verify.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions backend/plonk/bls24-317/verify.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions backend/plonk/bn254/verify.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions backend/plonk/bw6-633/verify.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions backend/plonk/bw6-761/verify.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions backend/plonk/plonk_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,13 @@ func TestProver(t *testing.T) {
err = plonk.Verify(proof, vk, publicWitness)
assert.NoError(err)

// testing with full witness should output a clear error.
err = plonk.Verify(proof, vk, fullWitness)
assert.Error(err)

// check that error contains "witness length is invalid"
assert.Contains(err.Error(), "witness length is invalid")

})

}
Expand Down
5 changes: 5 additions & 0 deletions internal/generator/backend/template/zkpschemes/plonk/plonk.verify.go.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (

var (
errWrongClaimedQuotient = errors.New("claimed quotient is not as expected")
errInvalidWitness = errors.New("witness length is invalid")
)

func Verify(proof *Proof, vk *VerifyingKey, publicWitness fr.Vector, opts ...backend.VerifierOption) error {
Expand All @@ -37,6 +38,10 @@ func Verify(proof *Proof, vk *VerifyingKey, publicWitness fr.Vector, opts ...bac
return errors.New("BSB22 Commitment number mismatch")
}

if len(publicWitness) != int(vk.NbPublicVariables) {
return errInvalidWitness
}


// transcript to derive the challenge
fs := fiatshamir.NewTranscript(cfg.ChallengeHash, "gamma", "beta", "alpha", "zeta")
Expand Down