Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hash registry with statestorer #564

Merged
merged 19 commits into from
Dec 11, 2024
Merged

feat: hash registry with statestorer #564

merged 19 commits into from
Dec 11, 2024

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Dec 4, 2024

Continuation of #560.

@ivokub
Copy link
Collaborator Author

ivokub commented Dec 4, 2024 •
edited
Loading

Depends on Consensys/bavard#9, but when upgrading to this version, then also introduced a lot of other changes in the generated code.

(removed dependency on the upgrade to avoid unrelated code generation updates)

@ivokub ivokub mentioned this pull request Dec 4, 2024
Closed
10 tasks
@ivokub ivokub self-assigned this Dec 9, 2024
@ivokub ivokub marked this pull request as ready for review December 9, 2024 11:16
@ivokub ivokub added the consolidate strengthen an existing feature label Dec 9, 2024
gbotrel
gbotrel requested changes Dec 9, 2024
View reviewed changes
internal/generator/crypto/hash/mimc/template/tests/mimc_test.go.tmpl Outdated Show resolved Hide resolved
internal/generator/crypto/hash/mimc/template/tests/mimc_test.go.tmpl Outdated Show resolved Hide resolved
hash/doc.go Show resolved Hide resolved
hash/hashes.go Outdated Show resolved Hide resolved
AlexandreBelling and others added 19 commits December 10, 2024 21:13
@AlexandreBelling @ivokub
feat(mimc): adds wSetState and State methods to mimc. And makes it a …
0c5dc3a 
…pointer receiver
@ivokub
feat: add hash.StateStorer interface
bf5500b
@ivokub
refactor: make digest private
c8d34e1
@ivokub
chore: go generate mimc
46631c1
@ivokub
test: implement mimc test (also code generate bn254 mimc test)
e1f3315
@ivokub
chore: remove unused remove in generate
bb8729f
@ivokub
chore: go generate
2d7d7e7
@ivokub
feat: implement registry based approach for gnark hashes
5947a57
@ivokub
feat: register MiMC in registry
ebf3397
@ivokub
feat: return statestorer directly
492e360
@ivokub
feat: use bavard opt instead of upgrade
07d392b
@ivokub
test: use direct hash constructor in EdDSA example
d44b9af
@ivokub
fix: check actual number of state bytes
b96e237
@ivokub
chore: we have underscorized name as var already
e904afb
@ivokub
fix: comment on the number of filler bytes
fd875cd
@ivokub
docs: explicit about package being kept for backwards compatibility
6726680
@ivokub
docs: describe action in panic
058a0ae
@ivokub
fix: fix odd MIMC string names
b65b2fa
@ivokub
fix: new headers
4b111bc
@ivokub ivokub force-pushed the feat/hash-statestorer-registry branch from 4d48360 to 4b111bc Compare December 10, 2024 21:14
ivokub
ivokub commented Dec 10, 2024
View reviewed changes
Copy link
Collaborator Author

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved issues. Also rebased on top of master due to bavard upgrade.

internal/generator/crypto/hash/mimc/template/tests/mimc_test.go.tmpl Outdated Show resolved Hide resolved
internal/generator/crypto/hash/mimc/template/tests/mimc_test.go.tmpl Outdated Show resolved Hide resolved
hash/doc.go Show resolved Hide resolved
hash/hashes.go Outdated Show resolved Hide resolved
@ivokub ivokub requested a review from gbotrel December 10, 2024 21:16
@ivokub ivokub merged commit be3c2bb into master Dec 11, 2024
5 checks passed
@ivokub ivokub deleted the feat/hash-statestorer-registry branch December 11, 2024 08:32
@AlexandreBelling AlexandreBelling mentioned this pull request Dec 11, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreBelling AlexandreBelling AlexandreBelling approved these changes

@gbotrel gbotrel gbotrel approved these changes

Assignees

@ivokub ivokub

Labels
consolidate strengthen an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivokub @gbotrel @AlexandreBelling