Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFT fails when size of domain is one + bug on the precomputed coset values for coset>1 #49

Closed
ThomasPiellard opened this issue May 10, 2021 · 0 comments · Fixed by #70
Closed

FFT fails when size of domain is one + bug on the precomputed coset values for coset>1 #49

ThomasPiellard opened this issue May 10, 2021 · 0 comments · Fixed by #70
Labels
bug Something isn't working

Comments

@ThomasPiellard
Copy link
Contributor

  • d := NewDomain(1, 1, false) triggers a panic
  • cosetGensInv[i].Mul(&cosetGensInv[1], &d.FinerGeneratorInv) instead of cosetGensInv[i].Mul(&cosetGensInv[i-1], &d.FinerGeneratorInv).

The error didn't trigger failing tests in PLONK, because only the FFT (not FFTInverse) is used on cosets > 1, on which there is no error. The FFTInverse on cosets is used only for the first coset, on which there is no error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v0.5.0 Consensys/gnark-crypto
2 participants
@gbotrel @ThomasPiellard