Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream Inspector: Add metrics #971

Merged
merged 13 commits into from
Apr 4, 2023
Merged

Stream Inspector: Add metrics #971

merged 13 commits into from
Apr 4, 2023

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Mar 29, 2023

Description

Adds metrics for the number of inspector sessions per connector or processor.

Fixes #742.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso changed the title Haris/stream inspector add metrics Stream Inspector: Add metrics Mar 29, 2023
@hariso hariso marked this pull request as ready for review March 30, 2023 14:00
@hariso hariso requested a review from a team as a code owner March 30, 2023 14:00
lovromazgon
lovromazgon reviewed Apr 3, 2023
View reviewed changes
lovromazgon
lovromazgon approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hariso @lovromazgon
Update docs/metrics.md
7774018 
Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com>
@hariso hariso enabled auto-merge (squash) April 4, 2023 08:13
@hariso hariso merged commit 0f2ead2 into main Apr 4, 2023
@hariso hariso deleted the haris/stream-inspector-add-metrics branch April 4, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stream Inspector: Add metrics
2 participants
@hariso @lovromazgon