DLQ Metrics #794
Merged
DLQ Metrics #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariso
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
Looks great to me! I have one question and one suggestion:
- WDYT about adding metrics related to the number of records which went through a DLQ (if we don't have that somewhere)?
- It would be nice to mention these metrics in docs/metrics.md and maybe also docs.conduit.io
The count is exposed through both histograms, no need to have a separate metric for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces metrics
conduit_dlq_execution_duration_secondsandconduit_dlq_bytes. Internally it introducesmetrics.RecordBytesHistogramwhich is a utility to observe record sizes (previously this code was instream.MetricsNode).Fixes #721
Quick checks: