-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Stream inspector design #692
Conversation
… into haris/stream-inspector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should dive just a bit deeper into the implementation options, specifically we should explore how we can extract records while they are flowing through the pipeline. I see at least two options:
- somehow wrap the connector
Read
andWrite
functions as well as the processorProcess
function - or give the
PubNode
andSubNode
the ability to somehow attach to it and inspect incoming/outgoing records.
The second option is more generic (we write it once and can attach to any node), but we currently can't address running nodes, they are spawned and run but not stored anywhere.
Maybe there's an even better solution, but in any case, I think it's worth discussing here.
Good callouts! I didn't mention those for two reasons: I wanted to make sure we're all on the same page w/r to the requirements. And I felt like it's more of a thing for the PRs and so I left the implementation in the design doc high-level. But I can mention it in this PR as well.
How about this though? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
Quick checks: