Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Stream inspector design #692

Merged
merged 27 commits into from
Nov 8, 2022
Merged

docs: Stream inspector design #692

merged 27 commits into from
Nov 8, 2022

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Oct 25, 2022

Description

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso marked this pull request as ready for review October 27, 2022 10:16
@hariso hariso requested a review from a team as a code owner October 27, 2022 10:16
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should dive just a bit deeper into the implementation options, specifically we should explore how we can extract records while they are flowing through the pipeline. I see at least two options:

  • somehow wrap the connector Read and Write functions as well as the processor Process function
  • or give the PubNode and SubNode the ability to somehow attach to it and inspect incoming/outgoing records.

The second option is more generic (we write it once and can attach to any node), but we currently can't address running nodes, they are spawned and run but not stored anywhere.

Maybe there's an even better solution, but in any case, I think it's worth discussing here.

@hariso
Copy link
Contributor Author

hariso commented Oct 27, 2022

I think we should dive just a bit deeper into the implementation options, specifically we should explore how we can extract records while they are flowing through the pipeline. I see at least two options:

Good callouts! I didn't mention those for two reasons: I wanted to make sure we're all on the same page w/r to the requirements. And I felt like it's more of a thing for the PRs and so I left the implementation in the design doc high-level. But I can mention it in this PR as well.

but we currently can't address running nodes, they are spawned and run but not stored anywhere.

How about this though?

@hariso hariso changed the title WIP: Stream inspector design Stream inspector design Oct 31, 2022
@hariso hariso changed the title Stream inspector design docs: Stream inspector design Oct 31, 2022
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hariso hariso enabled auto-merge (squash) November 8, 2022 18:56
@hariso hariso mentioned this pull request Nov 8, 2022
5 tasks
@hariso hariso merged commit fa614d6 into main Nov 8, 2022
@hariso hariso deleted the haris/stream-inspector branch November 8, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants