Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support writing custom Conduit apps with the CLI included #2180

Merged
merged 11 commits into from
Feb 28, 2025
Merged

Support writing custom Conduit apps with the CLI included #2180

merged 11 commits into from
Feb 28, 2025

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Feb 27, 2025 •
edited
Loading

Description

Fixes #2150.

Based on #2177.

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso requested a review from a team as a code owner February 27, 2025 11:33
@hariso hariso changed the title Haris/custom conduit with cli Support writing custom Conduit apps with the CLI included Feb 27, 2025
raulb
raulb reviewed Feb 27, 2025
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is needed to specify a configuration rather than relying on ecdysis to parse it?

raulb
raulb approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Only left one naming suggestion.

hariso and others added 3 commits February 28, 2025 14:36
@hariso @raulb
Update cmd/conduit/cli/cli.go
909a65c 
Co-authored-by: Raúl Barroso <ra.barroso@gmail.com>
@hariso @raulb
Update cmd/conduit/root/root.go
7450e37 
Co-authored-by: Raúl Barroso <ra.barroso@gmail.com>
@hariso @raulb
Update cmd/conduit/root/root.go
0eb688c 
Co-authored-by: Raúl Barroso <ra.barroso@gmail.com>
@hariso hariso enabled auto-merge (squash) February 28, 2025 13:37
@hariso hariso merged commit 2e16bbf into main Feb 28, 2025
3 checks passed
@hariso hariso deleted the haris/custom-conduit-with-cli branch February 28, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide example of custom Conduit with the CLI included
2 participants
@hariso @raulb