Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docker image for arm64 #2152

Merged
merged 2 commits into from
Feb 13, 2025
Merged

feat: add docker image for arm64 #2152

merged 2 commits into from
Feb 13, 2025

Conversation

raulb
Copy link
Member

@raulb raulb commented Feb 13, 2025

Description

Doing some benchmark tests I realized that conduit's image wasn't available for linux/arm64 (M4, etc...). (linux/arm64 is my current environment):

docker-compose -f containers/docker-compose.yml up -d

[+] Running 1/1
 ✔ conduit Pulled                                                                                                                                                                                                                                                                                                     0.7s 
[+] Running 0/0
 ⠋ Container conduit         Creating                                                                                                                                                                                                                                                                                 0.0s 
 ⠋ Container control-center  Creating                                                                                                                                                                                                                                                                                 0.0s 
Error response from daemon: No such image: ghcr.io/conduitio/conduit:v0.13.1

Notice platform is not available here:

docker manifest inspect ghcr.io/conduitio/conduit:v0.13.1
{
	"schemaVersion": 2,
	"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
	"config": {
		"mediaType": "application/vnd.docker.container.image.v1+json",
		"size": 2288,
		"digest": "sha256:0cfa91538c1a788cbebabd60528cb5f9e28ac7ed16574be9b2008420b8e8a42a"
	},
	"layers": [
		{
			"mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
			"size": 3641715,
			"digest": "sha256:1f3e46996e2966e4faa5846e56e76e3748b7315e2ded61476c24403d592134f0"
		},
		{
			"mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
			"size": 93,
			"digest": "sha256:56fae540d408b3eab074300dbe2f46d6ddc652b97d4c4c87b706b39c62186b77"
		},
		{
			"mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
			"size": 40511163,
			"digest": "sha256:8cbed761139c2622e2dc610720baecc3cc91d9de53235939ca9b2141c969a110"
		}
	]
}

In the meantime

You can build for linux/arm64 locally by doing:

$ (conduitio/conduit) docker buildx build --platform linux/arm64 -t ghcr.io/conduitio/conduit:v0.13.1 --load .

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb raulb requested a review from a team as a code owner February 13, 2025 14:06
@raulb raulb self-assigned this Feb 13, 2025
@raulb raulb merged commit a2137fe into main Feb 13, 2025
3 checks passed
@raulb raulb deleted the update-docker-platform branch February 13, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants