Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Conduit is run with conduit run and not with conduit anymore #2066

Merged
merged 8 commits into from
Jan 13, 2025
Merged

docs: Conduit is run with conduit run and not with conduit anymore #2066

merged 8 commits into from
Jan 13, 2025

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Jan 10, 2025 •
edited
Loading

Description

Part of #2065.

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso requested a review from a team as a code owner January 10, 2025 15:28
@hariso hariso enabled auto-merge (squash) January 10, 2025 17:58
lovromazgon
lovromazgon approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks, use your own judgment if you want to accept them 😉 LGTM!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
hariso and others added 4 commits January 13, 2025 17:21
@hariso @lovromazgon
Update README.md
c91be29 
Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com>
@hariso @lovromazgon
Update README.md
a57cf32 
Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com>
@hariso @lovromazgon
Update README.md
7c52b1c 
Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com>
@hariso
Merge branch 'main' into haris/conduit-run-docs
81793d4
@hariso hariso merged commit 12fb171 into main Jan 13, 2025
4 checks passed
@hariso hariso deleted the haris/conduit-run-docs branch January 13, 2025 16:27
@hariso hariso mentioned this pull request Jan 13, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hariso @lovromazgon