Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OpenCDC unwrap #1343

Merged
merged 5 commits into from
Jan 30, 2024
Merged

fix: OpenCDC unwrap #1343

merged 5 commits into from
Jan 30, 2024

Conversation

samirketema
Copy link
Contributor

@samirketema samirketema commented Jan 23, 2024 •
edited by raulb
Loading

Description

Fixes #1351

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@samirketema samirketema changed the title progress for opencdc unwrap WIP: opencdc unwrap Jan 23, 2024
@raulb raulb changed the title WIP: opencdc unwrap fix: OpenCDC unwrap Jan 25, 2024
@raulb raulb marked this pull request as ready for review January 29, 2024 17:37
@raulb raulb requested a review from a team as a code owner January 29, 2024 17:37
@raulb raulb force-pushed the samir/add-opencdc-unwrap-processor branch from 4e94216 to e437915 Compare January 29, 2024 17:48
@samirketema
Copy link
Contributor Author

@raulb I left a few nits. Also, do you mind updating the description of the PR since it's ready for review? Thank you so much for carrying this to the finish line 🙇🏾

@raulb raulb force-pushed the samir/add-opencdc-unwrap-processor branch from f250f7d to 79ff3e9 Compare January 30, 2024 10:45
samirketema and others added 3 commits January 30, 2024 11:52
@raulb raulb force-pushed the samir/add-opencdc-unwrap-processor branch from d83b63c to 9bb8010 Compare January 30, 2024 10:52
@raulb raulb requested a review from hariso January 30, 2024 12:15
hariso
hariso approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥇

@nassor nassor merged commit dccde3f into main Jan 30, 2024
3 checks passed
@nassor nassor deleted the samir/add-opencdc-unwrap-processor branch January 30, 2024 15:27
@raulb raulb mentioned this pull request Jan 31, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb left review comments

@nassor nassor nassor approved these changes

@hariso hariso hariso approved these changes

@lyuboxa lyuboxa lyuboxa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Double-wrapped OpenCDC records
5 participants
@samirketema @nassor @raulb @hariso @lyuboxa