[WIP] Processor plugin #1308
Closed
[WIP] Processor plugin #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariso
reviewed
Dec 8, 2023
Comment on lines
+79
to
+80
| SourceParams map[string]Parameter | ||
| DestinationParams map[string]Parameter |
There was a problem hiding this comment.
This comes probably from the connector SDK, but I believe we need only params for processors.
hariso
reviewed
Dec 11, 2023
| // records. | ||
| // | ||
| //nolint:revive // This interface will be moved into the SDK | ||
| type ProcessorPlugin interface { |
There was a problem hiding this comment.
As per the conversation we had earlier: ConduitIO/conduit-processor-sdk#1
Base automatically changed from
lovro/refactor-connector-plugin
to
feature/better-processors
January 9, 2024 18:34
|
Closing in favor of #1322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a processor plugin and a builtin registry.
We should move the plugin interface into the SDK to simplify things. Then the plugin doesn't have to import Conduit and Conduit doesn't have to translate objects when sending them to the plugin (at least if it's a builtin plugin). This makes the architecture quite a bit faster and simpler than what we currently have with connector plugins.
Related to #1285
Quick checks: