Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add periods as allowed ids + fix http log #1307

Merged
merged 2 commits into from
Dec 7, 2023
Merged

add periods as allowed ids + fix http log #1307

merged 2 commits into from
Dec 7, 2023

Conversation

maha-hajja
Copy link
Contributor

@maha-hajja maha-hajja commented Dec 7, 2023 •
edited
Loading

Description

periods should be allowed characters for a connector id

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-hajja maha-hajja requested a review from a team as a code owner December 7, 2023 18:29
@maha-hajja maha-hajja requested a review from AdamHaffar December 7, 2023 18:31
@lovromazgon lovromazgon merged commit bda52d4 into main Dec 7, 2023
3 checks passed
@lovromazgon lovromazgon deleted the maha/fix-connector-id branch December 7, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

@AdamHaffar AdamHaffar Awaiting requested review from AdamHaffar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maha-hajja @lovromazgon