allow for different args with conduit > 12 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyuboxa
reviewed
Feb 26, 2025
pkg/conduit/version.go
Outdated
| // runtime container depending on the conduit version. | ||
| func ArgsByVersion(version string, pipelineFile string, connectorsPath string, dbPath string, processorsPath string) []string { | ||
| var args []string | ||
| if version < "v0.12.0" { |
There was a problem hiding this comment.
Does this comparison work?;-)
There was a problem hiding this comment.
I checked it in go playground and the unit tests worked
There was a problem hiding this comment.
Right, but this is true because the strings are compared lexically. Even though 'v0.12.0.' and 'v0.12' are the same the comparison will return one being larger. So while the comparison here holds true, this is a side effect because versions are made of increasing numbers. Using the semver pkg provides a deterministic comparison between any version string.
There was a problem hiding this comment.
Makes sense, updated to use the semver package for version comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Conduit > 0.12 changed the formatting for args. Allow for different args on container creation to accommodate future upgrade.
Quick checks: