Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add extra log metrics for snapshot progress #162

Merged
merged 2 commits into from
Jun 13, 2024
Merged

add extra log metrics for snapshot progress #162

merged 2 commits into from
Jun 13, 2024

Conversation

lyuboxa
Copy link
Contributor

@lyuboxa lyuboxa commented May 30, 2024 •
edited
Loading

Description

Expand logging entries.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

lyuboxa
lyuboxa commented Jun 7, 2024
View reviewed changes
source/logrepl/handler.go Outdated Show resolved Hide resolved
@lyuboxa lyuboxa force-pushed the lk/extra-logging branch from 272fc29 to 36213f1 Compare June 13, 2024 17:40
@lyuboxa lyuboxa marked this pull request as ready for review June 13, 2024 17:40
@lyuboxa lyuboxa requested a review from a team as a code owner June 13, 2024 17:40
@lyuboxa lyuboxa enabled auto-merge (squash) June 13, 2024 17:57
hariso
hariso approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

source/logrepl/cdc.go Show resolved Hide resolved
@lyuboxa lyuboxa merged commit 66d545c into main Jun 13, 2024
3 checks passed
@lyuboxa lyuboxa deleted the lk/extra-logging branch June 13, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariso hariso hariso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyuboxa @hariso