manual fixes

ConduitIO · Jun 20, 2024 · baf453b · baf453b
1 parent 3ca35a2
commit baf453b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/destination.go b/destination.go
@@ -49,8 +49,8 @@ func (d *Destination) Parameters() config.Parameters {
 	return d.config.Parameters()
 }
 
-func (d *Destination) Configure(_ context.Context, cfg config.Config) error {
-	err := sdk.Util.ParseConfig(ctx, cfg, &d.config)
+func (d *Destination) Configure(ctx context.Context, cfg config.Config) error {
+	err := sdk.Util.ParseConfig(ctx, cfg, &d.config, NewDestination().Parameters())
 	if err != nil {
 		return err
 	}

diff --git a/source.go b/source.go
@@ -54,8 +54,8 @@ func (s *Source) Parameters() config.Parameters {
 	return s.config.Parameters()
 }
 
-func (s *Source) Configure(_ context.Context, cfg config.Config) error {
-	err := sdk.Util.ParseConfig(ctx, cfg, &s.config)
+func (s *Source) Configure(ctx context.Context, cfg config.Config) error {
+	err := sdk.Util.ParseConfig(ctx, cfg, &s.config, NewSource().Parameters())
 	if err != nil {
 		return err
 	}
@@ -147,7 +147,7 @@ func (s *Source) Teardown(ctx context.Context) error {
 	return errors.Join(errs...)
 }
 
-func (s *Source) LifecycleOnDeleted(ctx context.Context, cfg map[string]string) error {
+func (s *Source) LifecycleOnDeleted(ctx context.Context, cfg config.Config) error {
 	if err := s.Configure(ctx, cfg); err != nil {
 		return fmt.Errorf("fail to handle lifecycle delete event: %w", err)
 	}

diff --git a/source_integration_test.go b/source_integration_test.go
@@ -39,7 +39,6 @@ func TestSource_Open(t *testing.T) {
 			"tables":                  tableName,
 			"snapshotMode":            "initial",
 			"cdcMode":                 "logrepl",
-			"tableKeys":               "'id",
 			"logrepl.slotName":        slotName,
 			"logrepl.publicationName": publicationName,
 		},