Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify generated operation #72

Merged
merged 7 commits into from
Apr 4, 2024
Merged

specify generated operation #72

merged 7 commits into from
Apr 4, 2024

Conversation

maha-hajja
Copy link
Contributor

@maha-hajja maha-hajja commented Apr 4, 2024

Description

adds a param to specify the generated record's operation, can be "create", "update", "delete", "snapshot" and "random" to randomize one of the four operations.

Fixes #67

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-hajja maha-hajja requested a review from a team as a code owner April 4, 2024 05:41
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but I'm concerned if we ship this without making the changes to actually make use of this operation. i.e.: One user could see this and try it out, but then it wouldn't take any effect. I think we shouldn't merge this to main unless we complete the functionality.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@raulb
Copy link
Member

raulb commented Apr 4, 2024

Code looks good, but I'm concerned if we ship this without making the changes to actually make use of this operation. i.e.: One user could see this and try it out, but then it wouldn't take any effect. I think we shouldn't merge this to main unless we complete the functionality.

Scratch that! I forgot the generator is going to really "simply" include the operation in the generated record, but not mutate it any other way!

record_generator.go Outdated Show resolved Hide resolved
maha-hajja and others added 4 commits April 4, 2024 09:08
Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com>
Co-authored-by: Raúl Barroso <ra.barroso@gmail.com>
Co-authored-by: Raúl Barroso <ra.barroso@gmail.com>
@maha-hajja maha-hajja merged commit c731ead into main Apr 4, 2024
2 checks passed
@maha-hajja maha-hajja deleted the maha/operation-param branch April 4, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate different types of operations
3 participants