Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove transaction logging #395

Merged
merged 5 commits into from
Jun 23, 2022
Merged

Remove transaction logging #395

merged 5 commits into from
Jun 23, 2022

Conversation

abizjak
Copy link
Contributor

@abizjak abizjak commented Jun 17, 2022 •
edited
Loading

Purpose

Closes #396

Changes

  • Remove the abstractions that are used only for the transaction logging in the node.
  • Remove the node flags related to transaction logging
  • Remove libpq installation from build and similar supporting scripts.

Depends on

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@abizjak
Remove transaction logging functionality from the node.
fb35128 
This simplifies some of the type abstractions, removing some parameters and
typeclasses. It also removes a difficult dependency and makes the node not
depend on libpq anymore.
@abizjak abizjak requested review from td202 and limemloh June 17, 2022 18:59
@abizjak abizjak marked this pull request as ready for review June 17, 2022 18:59
@abizjak abizjak force-pushed the remove-transaction-logging branch from b9b1867 to 1037c4e Compare June 17, 2022 19:50
limemloh
limemloh previously approved these changes Jun 20, 2022
View reviewed changes
@limemloh limemloh self-requested a review June 20, 2022 13:02
@limemloh limemloh dismissed their stale review June 20, 2022 13:04

Misclick

limemloh
limemloh approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@limemloh limemloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me.

I have some findings which might be intentional:

  1. The document concordium-node/README.md still lists PostgreSQL as a dependency of the node. Is this still true?
  2. The document docs/data-storage.md still contains a description of the postgress layout which would be better to have with the external logging tool.
  3. The script concordium-node/scripts/static-binaries/build-on-ubuntu.sh still installs postgresql.
  4. The windows installer licenses resource still contains the PostgreSQL license.
  5. docker-compose/Dockerfile still installs PostgreSQL and is also mentioned in the docker-compose/README.md

td202
td202 approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@td202 td202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recursive postgres deps can be removed from Windows installer. The licenses for the installer should be updated, but perhaps this can be a separate task/PR. Otherwise looks good.

@abizjak abizjak merged commit dab93f8 into main Jun 23, 2022
@abizjak abizjak deleted the remove-transaction-logging branch June 23, 2022 15:11
@bisgardo bisgardo mentioned this pull request Jun 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@td202 td202 td202 approved these changes

@limemloh limemloh limemloh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove transaction logging functionality from the node
3 participants
@abizjak @td202 @limemloh