Add tests for plot and movie and QG #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I'm ok with merging this (maybe after #95). I haven't reviewed carefully, but I'll go though all the tests together carefully in the future |
fixed typo for passing optional 'size' argument to the movie functions
|
Added fix for #91 |
Steven-Roberts
requested changes
Jul 7, 2023
tests/+problemtests/validateqg.m
Outdated
| model = otp.quasigeostrophic.presets.PopovMouIliescuSandu('size', [16, 32]); | ||
| model.TimeSpan = [0, 0.109]; | ||
| catch | ||
| % if it failed to build, other tests would show it. |
There was a problem hiding this comment.
I think the try catch is unnecessary for this reason
tests/validateallderivatives.m
Outdated
| @@ -19,15 +19,15 @@ | |||
| presetname); | |||
|
|
|||
| try | |||
| model = eval(presetclass); | |||
| problem = eval(presetclass); | |||
| catch | |||
| continue; | |||
There was a problem hiding this comment.
Probably don't need try catch
tests/validateallplots.m
Outdated
| try | ||
| problem = eval(presetclass); | ||
| catch | ||
| continue; |
tests/validateallplots.m
Outdated
| end | ||
|
|
||
| try | ||
| problem.plot(sol); |
There was a problem hiding this comment.
fig = problem.plot(sol);
close(fig)
|
Add option to test plots but not movies in Octave. We can test what will happen on GitHub by running Octave without graphics. Hopefully the plots will display in the terminal! |
|
TODO: fix formatting of PASS in table for some problems |
|
I think this one is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.