Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correction to laser pulse formular for few-cycle wavepackets #875

Merged

Conversation

stetie
Copy link

@stetie stetie commented May 20, 2015

Similiar to #851, this corrects the laser pulse formular to account for extra terms arrising from deriving the formular from the vector potential. It ensures the integration along the propagation direction is 0. This is important for few-cycle laser pulses.

@PrometheusPi
Copy link
Member

@stetie Great job. 👍

@ax3l Please add @stetie to the developer list.
@BeyondEspresso When we discussed about this for #851, you said this approach only works for constant transversal envelopes. Is this true?

@PrometheusPi PrometheusPi added the bug a bug in the project's code label May 20, 2015
@PrometheusPi PrometheusPi added this to the Open Beta milestone May 20, 2015
@PrometheusPi PrometheusPi self-assigned this May 20, 2015
@ax3l
Copy link
Member

ax3l commented May 20, 2015

added to developer team, welcome and thx for the first pull request! 🚀

just git commit --amend to the last commit and push -f it to trigger a new CI build :)

@ax3l
Copy link
Member

ax3l commented May 20, 2015

P.S.: pls reformat the style of your commit message a little :)

Correction to laser pulse formular for few-cycle wavepackets (same as for ComputationalRadiationPhysics#851)
@stetie stetie force-pushed the fix-laserWavepacket branch from b07c1fd to ebb77a2 Compare May 20, 2015 13:25
@@ -56,6 +59,9 @@ HINLINE float3_X laserLongitudinal(uint32_t currentStep, float_X& phase)
const double endUpramp = -0.5 * LASER_NOFOCUS_CONSTANT;
const double startDownramp = 0.5 * LASER_NOFOCUS_CONSTANT;

const double tau = PULSE_LENGTH / sqrt(2.0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gentle reminder to your spotted correction. same as in plane wave: should be

const double tau = PULSE_LENGTH * sqrt(2.0);

@PrometheusPi
Copy link
Member

Sinus pulse:
stefanlasersin

sum/amax = 1e-2 is OK

@PrometheusPi
Copy link
Member

Cosinus pulse:
stefanlasercos

sum/amax = 1.5e-2 is OK

PrometheusPi added a commit that referenced this pull request May 21, 2015
Fix: Correction to laser pulse formular for few-cycle wavepackets
@PrometheusPi PrometheusPi merged commit ef6c093 into ComputationalRadiationPhysics:dev May 21, 2015
@ax3l
Copy link
Member

ax3l commented May 21, 2015

weird offset in the envelope... hm.

what are the cells per lambda and how many steps did you propagate? -> 90/lambda_0 and 2k steps
how close are you to the CFL? -> ca 1.8 off

is this just a small offset due to dispersion and the envelope is from the analytical formula (-> yes)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug in the project's code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants