add multi particle support for plugins #794
Conversation
|
Great pull, thank you! |
| ## | ||
| ## placeholders must be substituted with the real data name | ||
| ## | ||
| ## SPECIES = species name e.g. e (electrons), i (ions) |
There was a problem hiding this comment.
let's write singular <species> and <field> here:
placeholders must be substituted with the real data name (remove the <>)
<species> = species name, e.g., e (electrons), i (ions)
<field> = field name, e.g., FieldE, FieldB, FieldJ
9bb2f25 to
1e9ca79
Compare
|
rebased and ready to merge |
- change prefix name schema to DATA_PLUGINDESCRIPTION e.g. e_rediation, e_energy, ... - use template sequence generator to combine plugins and data
change pattern to find energy files
add new plugin names to the macro documentation
update parameter names to activate plugins
- change TBG_macros.cfg documentation - remove emty line in CountParticles.hpp
1e9ca79 to
9fff5e2
Compare
|
btw: this is a pretty deep change for users, since many output files change. we need to document that in the changelog (comment added in description) |
| typedef Radiation<PIC_Electrons> RadiationElectrons; | ||
| #endif | ||
| #endif | ||
| /** apply vector component one to component zero |
There was a problem hiding this comment.
- if it is
vector<dataType,plugin>than you apply el. 0 in el. 1 :)
-> apply the 1st vector component to the 2nd
There was a problem hiding this comment.
pls update the year in this file when you change it :)
There was a problem hiding this comment.
I am not sure if you want to add the change commented as a todo above with this pull: #818
There was a problem hiding this comment.
I change the name of PngPlugin in a separate pull
- change documentation for `ApplyDataToPlugin` - rename type names with pattern `*Anonymous*` to `*Unspecialized*`
|
ready to merge |
|
thank you for the fantastic update! @ComputationalRadiationPhysics/picongpu-developers @ComputationalRadiationPhysics/picongpu-maintainers take care if you are an early adopter and using |
…upport-rb1 add multi particle support for plugins
|
Amazing! Wonderful work! |
This pull changes many names for plugin names and plugin output files -> explicitly mention in the next changelog.
*.cfgfilesplotNumericalHeatingThis pull request effected all
*.cfgfilesPlease do not merge before #802@PrometheusPi please also take a look to this pull request