Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mallocMC #5280

Merged

Conversation

chillenzer
Copy link
Contributor

@chillenzer chillenzer commented Feb 18, 2025

This PR pulls the latest dev of mallocMC. This is planned as a beta phase before the official 3.0.0 release of mallocMC. This version should already be feature complete. Please start testing and report any bugs.

It was a bit of a hassle to update because we need a recent patch of alpaka. Also, there has been a major update of mallocMC's cmake infrastructure, so that entailed a number of changes in PIConGPU's setup, as well as an interface change: mallocMC's allocator now takes an accelerator tag instead of an accelerator directly.

Used

git rm thirdParty/mallocMC/ -r && \
GIT_AUTHOR_NAME="Third Party" GIT_AUTHOR_EMAIL="picongpu@hzdr.de" git commit -m "Temporarily remove mallocMC" && \
GIT_AUTHOR_NAME="Third Party" GIT_AUTHOR_EMAIL="picongpu@hzdr.de" git subtree add --prefix thirdParty/mallocMC  git@github.com:alpaka-group/mallocMC.git dev --squash

@chillenzer chillenzer requested a review from ikbuibui February 18, 2025 10:48
@chillenzer chillenzer added bug a bug in the project's code refactoring code change to improve performance or to unify a concept but does not change public API component: third party third party libraries that are shipped and/or linked labels Feb 18, 2025
@chillenzer chillenzer added this to the 0.9.0 / next stable milestone Feb 18, 2025
This was referenced Feb 18, 2025
@chillenzer chillenzer marked this pull request as ready for review February 19, 2025 09:55
@chillenzer chillenzer marked this pull request as draft February 19, 2025 10:38
@chillenzer chillenzer marked this pull request as ready for review February 20, 2025 15:16
@ikbuibui ikbuibui merged commit 28825eb into ComputationalRadiationPhysics:dev Feb 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug in the project's code component: third party third party libraries that are shipped and/or linked refactoring code change to improve performance or to unify a concept but does not change public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants