Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix message header allocation #452

Conversation

psychocoderHPC
Copy link
Member

fix wrong usage of operator new, caused by pull #439

fix wrong usage of operator new
@psychocoderHPC psychocoderHPC added this to the Open Beta milestone May 28, 2014
@psychocoderHPC psychocoderHPC added bug and removed core labels May 28, 2014
@f-schmitt
Copy link
Member

@ax3l this one is important for rc5!

@f-schmitt
Copy link
Member

@ComputationalRadiationPhysics/picongpu-maintainers why hasn't this been spotted during automated testing? don't we run lwfa there with some plugins enabled?

@psychocoderHPC
Copy link
Member Author

This was no compiletime problem. We have no runtime testing.

@ax3l: This bug was not in rc5 (in the old version we use malloc instead of new)

@ax3l
Copy link
Member

ax3l commented May 28, 2014

@f-schmitt-zih #439 is not part of RC5 so it does not affect RC5

Testing: right now we run automated compile-time tests - that was a run time error. Run time tests are planned with #7 but not yet done.

@f-schmitt
Copy link
Member

I see

@f-schmitt
Copy link
Member

tested, works

f-schmitt pushed a commit that referenced this pull request May 28, 2014
@f-schmitt f-schmitt merged commit 5c6bb8a into ComputationalRadiationPhysics:dev May 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug in the project's code component: plugin in PIConGPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants