-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thermal boundary condition for particles #3858
Merged
psychocoderHPC
merged 4 commits into
ComputationalRadiationPhysics:dev
from
lennertsprenger:topic-thermalParticleBC
Oct 13, 2021
Merged
Add thermal boundary condition for particles #3858
psychocoderHPC
merged 4 commits into
ComputationalRadiationPhysics:dev
from
lennertsprenger:topic-thermalParticleBC
Oct 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbastrakov
added
component: core
in PIConGPU (core application)
component: user input
signals changes in user API such as .param files, .cfg syntax, etc. - changelog!
labels
Oct 8, 2021
psychocoderHPC
requested changes
Oct 11, 2021
sbastrakov
reviewed
Oct 11, 2021
sbastrakov
changed the title
add thermal boundary condition for particle
Add thermal boundary condition for particles
Oct 11, 2021
@lennertsprenger you were right, it is actually required to check for all crossings in thermal implementation. In that regard, it is different from absorbing and reflecting, which were fully separable. I now fixed it, and also added some comments explaining the reasoning |
sbastrakov
force-pushed
the
topic-thermalParticleBC
branch
from
October 11, 2021 16:37
d95d09f
to
083fb2b
Compare
sbastrakov
force-pushed
the
topic-thermalParticleBC
branch
from
October 12, 2021 07:51
083fb2b
to
c0734bc
Compare
@psychocoderHPC this PR is now finished and ready for re-review. |
psychocoderHPC
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: core
in PIConGPU (core application)
component: user input
signals changes in user API such as .param files, .cfg syntax, etc. - changelog!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My unfinished work since my time at the HZDR is over
In the thermal boundary condition the particles that crossed the simulation boundary will be thermaly radiated from the point where the particle would have hit the boundary, with the velocity from the Maxwell Boltzmann distribution.
TODO:
For now positive boundary offset is required (and checked for) due to #3850.
cc @steindev @sbastrakov