Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thermal boundary condition for particles #3858

Conversation

lennertsprenger
Copy link
Member

@lennertsprenger lennertsprenger commented Oct 8, 2021

My unfinished work since my time at the HZDR is over

In the thermal boundary condition the particles that crossed the simulation boundary will be thermaly radiated from the point where the particle would have hit the boundary, with the velocity from the Maxwell Boltzmann distribution.

TODO:

  • add temperature parameter
  • check that the new position after the thermalization is not outside of the boundary of another axis
  • extend docs

For now positive boundary offset is required (and checked for) due to #3850.

cc @steindev @sbastrakov

@sbastrakov sbastrakov added component: core in PIConGPU (core application) component: user input signals changes in user API such as .param files, .cfg syntax, etc. - changelog! labels Oct 8, 2021
@sbastrakov sbastrakov added this to the 0.7.0 / 1.0.0: Next Stable milestone Oct 8, 2021
@sbastrakov sbastrakov marked this pull request as ready for review October 11, 2021 10:00
include/picongpu/particles/boundary/Thermal.hpp Outdated Show resolved Hide resolved
include/picongpu/particles/boundary/Thermal.hpp Outdated Show resolved Hide resolved
include/picongpu/particles/boundary/Thermal.hpp Outdated Show resolved Hide resolved
@sbastrakov sbastrakov changed the title add thermal boundary condition for particle Add thermal boundary condition for particles Oct 11, 2021
@sbastrakov
Copy link
Member

@lennertsprenger you were right, it is actually required to check for all crossings in thermal implementation. In that regard, it is different from absorbing and reflecting, which were fully separable. I now fixed it, and also added some comments explaining the reasoning

@sbastrakov sbastrakov force-pushed the topic-thermalParticleBC branch from 083fb2b to c0734bc Compare October 12, 2021 07:51
@sbastrakov
Copy link
Member

sbastrakov commented Oct 12, 2021

@psychocoderHPC this PR is now finished and ready for re-review.

@psychocoderHPC psychocoderHPC merged commit c1c9117 into ComputationalRadiationPhysics:dev Oct 13, 2021
@lennertsprenger lennertsprenger deleted the topic-thermalParticleBC branch October 13, 2021 20:17
@steindev steindev mentioned this pull request Jan 21, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: core in PIConGPU (core application) component: user input signals changes in user API such as .param files, .cfg syntax, etc. - changelog!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants