Fix #165 Use Corrected CFL Criteria #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A. Taflove & M. E. Brodwin IEEE Trans. on Microwave Theory and Techniques, August 1975 Formula (7)
- shows selected and minimum possible ratio for time step - refactor to use log<picLog::PHYSICS> for standard sim output during startup
| std::cout << "typical macro particle weighting: " << NUM_EL_PER_PARTICLE << std::endl; | ||
| log<picLog::PHYSICS >("macro particles per gpu: %1%") % | ||
| (localNrOfCells * particleInit::NUM_PARTICLES_PER_CELL * (1 + 1 * ENABLE_IONS)); | ||
| log<picLog::PHYSICS >("typical macro particle weighting: %1%") % (NUM_EL_PER_PARTICLE); | ||
|
|
||
| //const float_X y_R = M_PI * laserProfile::W0 * laserProfile::W0 / laserProfile::WAVE_LENGTH; //rayleigh length (in y-direction) |
There was a problem hiding this comment.
Is it possible that you delete the dead code in this pull.
There was a problem hiding this comment.
It would be quite cool to put this in depending on the selected laser profile (works only for gaussian beam). but I didn't think it fully through yet. can we leave it in for now?
psychocoderHPC
added a commit
that referenced
this pull request
Apr 28, 2014
Fix #165 Use Corrected CFL Criteria
ax3l
added a commit
to ax3l/picongpu
that referenced
this pull request
Apr 29, 2014
…cs#371 - related to the pre-release question in ComputationalRadiationPhysics#378
PrometheusPi
added a commit
that referenced
this pull request
Apr 29, 2014
Add Documentation in CHANGELOG.md for CFL #371
ax3l
pushed a commit
to ax3l/picongpu
that referenced
this pull request
Aug 16, 2017
90ae873b9 Merge pull request ComputationalRadiationPhysics#382 from BenjaminW3/topic-CMake-3_9_followup aad3f6a5e add missing changes to alpaka_add_library d421e9a20 Merge pull request ComputationalRadiationPhysics#381 from BenjaminW3/topic-cmake-3_9 71fc4e7ed support CMake 3.9.0 441032e7f Merge pull request ComputationalRadiationPhysics#378 from ax3l/fix-uninitMemberMemcpy dea0bd0f4 Merge pull request ComputationalRadiationPhysics#379 from ax3l/fix-warningCudaBraces 8643a97f0 cudaMemcpy3DParams: Fix Uninit Members 182d1b64f Refactor: double-braces for std::array init a22e42a42 CUDA: Missing Initializer Warning ddb2993aa Merge pull request ComputationalRadiationPhysics#375 from BenjaminW3/topic-update-readme cf311c6a5 remove boost.context from ReadMe requirements e93d5ae49 Merge pull request ComputationalRadiationPhysics#374 from BenjaminW3/topic-remove-boost-atomic-dependency fe898716f remove unused boost atomic dependency 7a66700f2 Merge pull request ComputationalRadiationPhysics#371 from BenjaminW3/topic-duplicate-CUDA_NVCC_FLAGS 2f902cd70 Merge pull request ComputationalRadiationPhysics#372 from ax3l/topic-cmakeOptionalNoWarning 3f95afa83 CMake Config: Optional Deps 83a1bf3e6 Merge pull request ComputationalRadiationPhysics#369 from BenjaminW3/topic-clean-up-assertions a932c02d7 clean up CUDA_NVCC_FLAGS 9753ef6fa clean up assertions git-subtree-dir: thirdParty/alpaka git-subtree-split: 90ae873b9984071e64343995e7721bde6a13ba7f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Reference that corrected Yee's Paper
A. Taflove & M. E. Brodwin
IEEE Trans. on Microwave Theory and Techniques, August 1975
Formula (7)
Notes
Our "old" implemented CFL was not wrong in the sense of stability of the algorithm.
But it was too conservative for many cases that used non-cubic cells. This conservatism in turn causes numerical dispersion and should therefore be avoided.
In other words: stay as close as possible to the CFL with your time step to cell "ratio".