-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Jupyter widgets: automatic update of plot options #2911
[WIP] Jupyter widgets: automatic update of plot options #2911
Conversation
Thank you, that's a wonderful update!
Currently yes, since we compile in the general options and parametrize them at runtime. Nevertheless, we would like to change them at runtime potentially, e.g. with cling, and have done quite flexible functor chains with ISAAC already.
I think that would be a fantastic data (or even input reader) class. do you have an idea where to parse them from? We could also add such info to our |
@codingS3b What is the status of this pull request? Can I start reviewing? |
Sorry, kind of forgot about that issue. It is definitely not ready for review! So basically I would need some class that tells me (given a simulation output directory) which 'species' and which 'Species_filter' options are available for a chosen plugin (like the energy_histogram or the phase_space plugin). Once this functionality exists, the rest should be relatively easy (by using the options common to all selected simulations). |
Hm, it might help to have the openPMD plugin in place #2966 and dump at |
The |
The json backend is intentionally serial (and will likely stay that way for good). The idea is to make a single, |
@codingS3b Will you continue working on this pull request or should we close it (for now)? |
@PrometheusPi I am not working on this right now since I hope that, after converting all data readers to work with openPMD inputs, getting the necessary information will become much easier. So, if development on the readers is not close to being finished, this can be closed for now and re-opened later. |
@codingS3b Thanks for the input. I agree that this should be supported by the readers. As suggested I will close this pull request (for now). |
At the moment the options of each jupyter widget (like 'species' or 'species_filter') are hardcoded to a single option (see screenshot).
This PR will improve this situation by dynamically adapting those options based on the values common to the selected simulations.
Before implementing something we should discuss the following:
a) is it sufficient to update those parameters only when the selected simulations change? Or do we also update them when the selected simulation time changes or when any of the other options changes?
b) Should the query for available species, filters, and other options be implemented in the data classes or in the widget classes?