Topic clean vector #138
Merged
Topic clean vector #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
psychocoderHPC
commented
Jan 21, 2014
- add toString method for math::vector
- rename math::vector.volume() method to productOfComponents()
- delete all methods in DataSpace which not return a DataSpace and are defines in math::Vector
- use toString() to print DataSpace
- add toString method for math::vector - rename math::vector.volume method to productOfComponents - delete all methods in DataSpace which not return a DataDaspace and are defines in math::Vector
| @@ -117,14 +117,23 @@ struct Vector : public detail::Vector_components<Type, _dim>, _Accessor, _Naviga | |||
| typedef _Navigator Navigator; | |||
| typedef Vector<Type, dim, Accessor, Navigator> This; | |||
|
|
|||
| /*Vector without elements are not allowed*/ | |||
There was a problem hiding this comment.
Either
VectorS ... are not allowed
or
A vector ... is not allowed
|
All right, besides the minor inline comments you get my 👍 |
ax3l
added a commit
that referenced
this pull request
Jan 22, 2014
Refactor Vector/DataSpace implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.