Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart HDF5: Avoid 32bit Downcast in Offsets #719

Closed
ax3l opened this issue Feb 19, 2015 · 1 comment
Closed

Restart HDF5: Avoid 32bit Downcast in Offsets #719

ax3l opened this issue Feb 19, 2015 · 1 comment
Assignees
@ax3l
Labels
affects latest release a bug that affects the latest stable release bug a bug in the project's code component: plugin in PIConGPU plugin
Milestone
0.2.0: Open Beta

Comments

@ax3l
Copy link
Member

ax3l commented Feb 19, 2015

Similar to #666 but in HDF5 restart - the offsets are global here:

src/picongpu/include/plugins/hdf5/restart/LoadParticleAttributesFromHDF5.hpp

needs to be uint64_t... let's update elements just to be consistent, too.
@ax3l ax3l added bug a bug in the project's code component: plugin in PIConGPU plugin labels Feb 19, 2015
@ax3l ax3l self-assigned this Feb 19, 2015
@ax3l ax3l added this to the Open Beta milestone Feb 19, 2015
@ax3l ax3l added the affects latest release a bug that affects the latest stable release label Feb 19, 2015
ax3l added a commit to ax3l/picongpu that referenced this issue Feb 19, 2015
@ax3l
Fix ComputationalRadiationPhysics#719 Restart HDF5: Avoid 32bit Downcast
bee0d20 
- offsets are element offsets in the *global* particle
  attribute array (that can be more than uint32_t / size_t)
- elements are promoted to uint64_t too for convenience
psychocoderHPC added a commit that referenced this issue Feb 19, 2015
@psychocoderHPC
Merge pull request #721 from ax3l/fix-restartHDF5Offset
2a2debc 
Fix #719 Restart HDF5: Avoid 32bit Downcast
ax3l added a commit that referenced this issue Feb 19, 2015
@ax3l
Fix #719 Restart HDF5: Avoid 32bit Downcast
712430c 
- offsets are element offsets in the *global* particle
  attribute array (that can be more than uint32_t / size_t)
- elements are promoted to uint64_t too for convenience
@ax3l
Copy link
Member Author

ax3l commented Mar 9, 2015

closed in #721

@ax3l ax3l closed this as completed Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ax3l ax3l

Labels
affects latest release a bug that affects the latest stable release bug a bug in the project's code component: plugin in PIConGPU plugin
Projects
None yet
Milestone
0.2.0: Open Beta
Development

No branches or pull requests
1 participant
@ax3l