Meddling around in GetPusher.hpp etc. does not cause compile errors. - File obsolete?

[n01r]

In the following code, taken from particles/traits/GetPusher.hpp I changed ::ThisType into ::ThisStuff to provoke a compiler error, yet it didn't throw one.

#pragma once

#include "simulation_defines.hpp"
#include "traits/GetFlagType.hpp"

namespace picongpu
{

template<typename T_Species>
struct GetPusher
{
    typedef typename GetFlagType<typename T_Species::FrameType, particlePusher<> >::type::ThisStuff type; // I meddled here to find out how the template parameters on a crash look like

    //typedef typename GetFlagType<typename T_Species::FrameType, particlePusher<> >::type::ThisType type;
};

}// namespace picongpu

Is that file obsolete or maybe not yet state-of-the-art?
As I need to use the same syntax though it is important to find that out.

I am using my branch where the current dev has been merged into and I configured the standard LWFA example.

[ax3l]

a simple grep reveals that this trait is currently not used somewhere in the code. In that case it is not compiles and therefor "no error" while crashing it is totally fine.

Particles are pushed via the MySimulation::runOneStep() ForEach over src/picongpu/include/particles/ParticlesFunctors.hpp: CallUpdate.
You can see it uses HasFlag<FrameType, particlePusher<> directly and not the trait, one could also write GetPusher there which would be even better and provokes your error.

[ax3l]

Can this issue be closed?
@psychocoderHPC we could still use that trait in CallUpdate via a separate pull request to use the trait.

Update: just saw its a HasFlag trait there, not a GetFlag. So we can leave it as it is.

[n01r]

Probably it can be closed. No real need to leave it open until those traits have been made use of, I guess.