Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Data from DataConnector #218

Closed
psychocoderHPC opened this issue Feb 19, 2014 · 3 comments
Closed

Load Data from DataConnector #218

psychocoderHPC opened this issue Feb 19, 2014 · 3 comments
Assignees

Comments

@psychocoderHPC
Copy link
Member

We need a small interface change to support multi species in the future.
At the moment we load data from DataConnector with DataConnector::getInstance().getData<T_TYPE>(id,..).
Can we exchange the integer id with a unique string? At the moment we need a central place were we define unique ids (a enum in simulation_types.hpp), this means with multi species we must describe species in one param file and for every species we must change the global id enum per species. This are two places which must be changed to add a species.
Every species and field has a unique name, we should use this name to identify datasets.
e.g.

DataConnector::getInstance().getData<FrameType>(FrameType::getName(),..);
DataConnector::getInstance().getData<FieldB>(FieldB::getName(),..);

If we define that every dataset must have a static getName() method than we can fully skip the name from the interface and call the getName() method inside of the DataConnector to create a map were the key is the name.

DataConnector::getInstance().getData<FrameType>(..);
DataConnector::getInstance().getData<FieldB>(...);

IMO we can combine the interface change with #114

@ax3l ax3l added the feature label Feb 19, 2014
@ax3l ax3l modified the milestones: 1.0, Open Beta Feb 19, 2014
@f-schmitt
Copy link
Member

I would like to integrate this as a separate pull since it is not directly related to #114 and I find it to be cleaner if we have smaller oull requests.

@ax3l
Copy link
Member

ax3l commented Feb 24, 2014

👍 absolutely

@f-schmitt
Copy link
Member

Closed with #232

psychocoderHPC pushed a commit to psychocoderHPC/picongpu that referenced this issue Oct 8, 2021
ddba224b7 Merge pull request ComputationalRadiationPhysics#226 from psychocoderHPC/fix-wrongUBBitshift
886554a42 fix undefined shift value behavior
c90547653 Merge pull request ComputationalRadiationPhysics#225 from psychocoderHPC/topic-makeAccessblocksRuntime
1cf2e20e8 use runtime selected number of access blocks
bc2597731 Merge pull request ComputationalRadiationPhysics#224 from psychocoderHPC/fix-notAllRegionsScanned
07aa0536c fix: Scatter is not checking all regions
fa2196d47 Merge pull request ComputationalRadiationPhysics#222 from psychocoderHPC/topic-optimizeScatterPageSearch
92b9ea28d Merge pull request ComputationalRadiationPhysics#223 from psychocoderHPC/topic-scatterBetterSelfDescription
4e533dbac Scatter: add more informations to `classname()`
dacb9cfbd Scatter: optimize page search algorithm
30368417a Merge pull request ComputationalRadiationPhysics#220 from psychocoderHPC/topic-optimzeScatterHashAndAllocation
01730d0bb Scatter: optimize hash and allocation size
8ec3e514d Merge pull request ComputationalRadiationPhysics#221 from psychocoderHPC/fix-scatterAllocCalcAdditionalChunks
f0a05c6dc Merge pull request ComputationalRadiationPhysics#219 from psychocoderHPC/fix-possibleDataRaces
a3cc09a78 Update src/include/mallocMC/creationPolicies/Scatter.hpp
1cc3d15f0 Merge pull request ComputationalRadiationPhysics#218 from psychocoderHPC/fix-pagesizeAllocation
8f9f7147c Merge pull request ComputationalRadiationPhysics#217 from psychocoderHPC/topic-removeUnusedVariables
6b2bc00e5 fix `calcAdditionalChunks`
174a7b2aa fix data races
96379d4af fix scatter allocation
362eeceeb remove unused variables

git-subtree-dir: thirdParty/mallocMC
git-subtree-split: ddba224b764885f816c42a7719551b14e6f5752b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants