-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Com 1466 2 - Survey Card #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmolle
reviewed
Sep 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A voir avec Romain niveau UX, mais cote UI je trouve ca plus jolie finalement avec activeOpacity a 1. Comme SurveyScoreSelector change de visuel quand on clique dessus j'ai l'intuition que ce n'est pas genant mais verifie avec Romain :)
ulysseferreira
approved these changes
Sep 23, 2020
b0d229b
to
a1dde1c
Compare
a1dde1c
to
d442314
Compare
cmolle
reviewed
Sep 23, 2020
cmolle
reviewed
Sep 23, 2020
83014c3
to
eee7d0e
Compare
cmolle
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J'ai testé sur iphone
J'ai testé sur android
Cas d'usage :
Je peux voir une carte sondage et le résultat de l'utilisateur est stocké dans une variable. Le bouton pour passer à la carte suivante est bloqué tant que l'utilisateur n'a pas sélectionné de carte.
Refacto du NiButton et de QuestionCardFooter