New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Com 3853 #693

Merged

manonpalin merged 7 commits into dev from COM-3853

Dec 16, 2024

Collaborator

ulysseferreira commented Dec 11, 2024 •

edited

Loading

TESTS 💻

POINTS D'ATTENTION POUR CETTE PR ⚠️

~~J'ai ajouté une variable d'environnement~~
- Si oui, J'ai précisé sur le Doc de déploiement ce qu'il fallait mettre à jour
Mes changements entrainent une incompatibilité avec l'ancienne version de l'api
- Si oui, j'ai noté dans le Doc de déploiement qu'il faut fusionner l'api dans staging avant d'envoyer le build et déprécier les anciennes versions

Si tu as lu cette description, pense à réagir avec un 👁️

ulysseferreira added the dev label

ulysseferreira self-assigned this

ulysseferreira force-pushed the COM-3853 branch from 255fc95 to e24ee31 Compare

December 11, 2024 17:28

manonpalin reviewed

View reviewed changes

src/screens/courses/profile/LearnerCourseProfile/index.tsx Show resolved Hide resolved

manonpalin reviewed

View reviewed changes

src/components/questionnaires/PendingActionsContainer/index.tsx Outdated Show resolved Hide resolved

manonpalin reviewed

View reviewed changes

src/components/questionnaires/LearnerAttendanceSheetCell/index.tsx Outdated Show resolved Hide resolved

manonpalin reviewed

View reviewed changes

src/components/questionnaires/LearnerAttendanceSheetCell/index.tsx Outdated Show resolved Hide resolved

manonpalin reviewed

View reviewed changes

src/components/questionnaires/LearnerAttendanceSheetCell/styles.ts Outdated Show resolved Hide resolved

Collaborator

manonpalin commented Dec 13, 2024

Est-ce qu'on devrait pas renommer le dossier questionnaires ? Ca semble pas forcement intuitif que les cellules concernant les FE soient ici

Collaborator

manonpalin commented Dec 13, 2024

Est-ce que learner est indispensable dans learnerAttendanceSheetCell ?

ulysseferreira force-pushed the COM-3853 branch from 6a58e53 to 8f7bdc1 Compare

December 13, 2024 16:15

manonpalin reviewed

View reviewed changes

src/components/learnerPendingActions/PendingActionsContainer/styles.ts Show resolved Hide resolved

ulysseferreira added 7 commits

December 16, 2024 11:22


          COM-3853: wip


          COM-3853: optimize

9abf073


          COM-3853: fix

0732c86


          COM-3853: performance optimization proposal

ed56fcf


          COM-3853: manon's review

4efe663


          COM-3853: rename folder

020d06c


          COM-3853: add margin

ed965d9

ulysseferreira force-pushed the COM-3853 branch from 8f7bdc1 to ed965d9 Compare

December 16, 2024 10:27

manonpalin approved these changes

View reviewed changes

manonpalin merged commit ad308c0 into dev

3 checks passed

manonpalin deleted the COM-3853 branch

December 16, 2024 11:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev