Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PULL_REQUEST_TEMPLATE.md #3395

Merged
3 commits merged into from
Jul 23, 2020
Merged

Conversation

Kyaa-dost
Copy link
Contributor

Fixes #

Clear instructions on where to place the relevant issue number.

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

Lack of clear instructions causing confusion on where to place the issue number.

What is the new behavior?

Clear commented instructions on where to place the relevant issue numbers to assist bot in triggering "In-PR" label

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Jul 22, 2020

Thanks Kyaa-dost for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi July 22, 2020 18:21
@ghost
Copy link

ghost commented Jul 22, 2020

Hello @Kyaa-dost!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker
Copy link
Member

Thanks Kyaa!

While we're at this can we add the new 'May 2020 Update (19041)' to our list of SDKs?

Update May 2020 Update (19041)
@ghost ghost merged commit 8739735 into master Jul 23, 2020
@ghost ghost deleted the PR_Template-InstructionsClarification branch July 23, 2020 15:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants