Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow horizontal scrolling if the horizontal scrollbar is not disabled and the vertical scrollbar is disabled #3174

Merged

Conversation

skendrot
Copy link
Contributor

Fixes #3170

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

With a normal mouse you cannot scroll horizontal only DataGrids

What is the new behavior?

You can scroll with a normal mouse when the vertical scrollbar is disabled and the horizontal scrollbar is not disabled

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Contains NO breaking changes

Other information

None

…e has a horizontal wheel OR if the horizontal scrollbar is not disabled AND the vertical scrollbar IS disabled
@ghost
Copy link

ghost commented Mar 18, 2020

Thanks skendrot for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned Kyaa-dost Mar 18, 2020
Copy link
Contributor

@vgromfeld vgromfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@michael-hawker michael-hawker added this to the 6.1 milestone Mar 19, 2020
@michael-hawker michael-hawker merged commit 469d951 into CommunityToolkit:master Mar 24, 2020
@michael-hawker michael-hawker mentioned this pull request Mar 27, 2020
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Horizontal Scrolling
4 participants