Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabbedCommandBar MinVersion Conflict #3779

Closed
michael-hawker opened this issue Feb 23, 2021 · 3 comments · Fixed by #3813
Closed

TabbedCommandBar MinVersion Conflict #3779

michael-hawker opened this issue Feb 23, 2021 · 3 comments · Fixed by #3813
Assignees
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 controls 🎛️
Milestone

Comments

@michael-hawker
Copy link
Member

Describe the bug

Saw this warning in the CI:

 D:\a\1\s\Microsoft.Toolkit.Uwp.UI.Controls.Core\TabbedCommandBar\TabbedCommandBar.xaml(91,57): XamlCompiler warning WMC0151: Member 'ShouldConstrainToRootBounds' on type 'Windows.UI.Xaml.Controls.Primitives.IFlyoutBase6' is defined under contract 'Windows.Foundation.UniversalApiContract' version '8.0.0.0', but the contract version for the targeted min version is '7.0.0.0'! [D:\a\1\s\Microsoft.Toolkit.Uwp.UI.Controls.Core\Microsoft.Toolkit.Uwp.UI.Controls.Core.csproj]

Seems like we're using a property which isn't supported down to 1809. https://docs.microsoft.com/uwp/api/windows.ui.xaml.controls.primitives.flyoutbase.shouldconstraintorootbounds

Expected behavior

We need to remove property or add conditional XAML (which not sure if that's fixed yet? microsoft/microsoft-ui-xaml#2556)

FYI @yoshiask

@michael-hawker michael-hawker added bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ labels Feb 23, 2021
@michael-hawker michael-hawker added this to the 7.0 milestone Feb 23, 2021
@yoshiask
Copy link
Contributor

I saw that when I copied one of the WinUI styles over, but I can't remember which control it's for. I'll investigate when I get the chance.

@Kyaa-dost
Copy link
Contributor

@yoshiask really appreciate all your work ❤️ Do you think will be able to have a chance to check it out soon as we are about to Deploy 7.0?

@yoshiask
Copy link
Contributor

yoshiask commented Mar 6, 2021

It looks like the Intellisense suggestion of using a conditional namespace is enough. I'll open a PR when I get the chance today.

@ghost ghost added the In-PR 🚀 label Mar 6, 2021
michael-hawker added a commit that referenced this issue Mar 8, 2021
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Mar 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 controls 🎛️
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants