Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expander Header is hard to Stretch #3070

Closed
michael-hawker opened this issue Nov 22, 2019 · 4 comments · Fixed by #3769
Closed

Expander Header is hard to Stretch #3070

michael-hawker opened this issue Nov 22, 2019 · 4 comments · Fixed by #3769
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 in progress 🚧 next preview ✈️ Label for marking what we want to include in the next preview release for developers to try.
Milestone
7.0

Comments

@michael-hawker
Copy link
Member

Describe the bug

It's hard to cause the header of the Expander control to stretch across the size of the Expander. The problem is the HorizontalContentAlignment isn't exposed for the header from here

Expected behavior

Able to easily stretch the header of an Expander
@michael-hawker michael-hawker added the bug 🐛 An unexpected issue that highlights incorrect behavior label Nov 22, 2019
@ghost ghost added the needs triage 🔍 label Nov 22, 2019
@skendrot
Copy link
Contributor

The content of the header will "stretch" as much as is needed.... What's the use case/scenario that isn't working?

@michael-hawker
Copy link
Member Author

@skendrot if you have the expander stretch to its parent size, but then want to right-align anything within the header itself, you can't as the header content is left-aligned and not able to be stretched.

@hermitdave
Copy link
Contributor

image
I was trying to use Expander for this and found it very hard to customise the header. Eventually ended up with custom control rather than expander

@michael-hawker michael-hawker added this to the 6.1 milestone Dec 3, 2019
skendrot added a commit to skendrot/UWPCommunityToolkit that referenced this issue Jan 10, 2020
@skendrot
CommunityToolkit#3070 Stretch the content of the expander header
768cbc1
@skendrot skendrot mentioned this issue Jan 10, 2020
Closed
7 tasks
@ghost ghost added the In-PR 🚀 label Jan 10, 2020
@skendrot
Copy link
Contributor

You could easily change the HeaderStyle of the Expander to stretch the content. Don't need a new control.
I submitted a PR for this but it is a breaking visual change

@michael-hawker michael-hawker modified the milestones: 6.1, 7.0 Jun 1, 2020
@ghost ghost added the in progress 🚧 label Dec 9, 2020
@michael-hawker michael-hawker added the next preview ✈️ Label for marking what we want to include in the next preview release for developers to try. label Feb 17, 2021
@michael-hawker michael-hawker mentioned this issue Feb 18, 2021
Closed
@Rosuavio Rosuavio mentioned this issue Feb 19, 2021
Merged
7 tasks
michael-hawker added a commit that referenced this issue Feb 19, 2021
@michael-hawker
Merge pull request #3769 from RosarioPulella/expander-stretch-2
4b92896 
#3070 Stretch the content of the expander header
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Feb 19, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 in progress 🚧 next preview ✈️ Label for marking what we want to include in the next preview release for developers to try.
Projects
None yet
Milestone
7.0
4 participants
@skendrot @hermitdave @michael-hawker @Kyaa-dost