Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port SystemInformation and associated helpers #600

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Lamparter
Copy link

As referenced in #17

PR Type: Added new helpers (from WCT 7.x)

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component (is it a component?)
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • Contains NO breaking changes

SystemInformation and associated helpers StorageFileHelper, ApplicationDataStorageHelper and the OSVersion struct have not yet been ported. I have ported these in this PR, with support for multiple platforms (and Uno support(-ish)).

@Lamparter Lamparter marked this pull request as ready for review January 7, 2025 21:07
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I see the point of these APIs. Perhaps SystemInformation on its own, but most of the other APIs seem to be just very low value wrappers over system APIs. @Arlodotexe we should consider whether it makes sense to bring back these APIs at all.

@Arlodotexe
Copy link
Member

I'm not sure I see the point of these APIs. Perhaps SystemInformation on its own, but most of the other APIs seem to be just very low value wrappers over system APIs. @Arlodotexe we should consider whether it makes sense to bring back these APIs at all.

I agree, this needed proper evaluation as per #602.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants