[Housekeeping] Fix The active test run was aborted. Reason: Test host process crashed
#2206
Conversation
|
Oh fun - the pipeline is now failing with a new error:
|
|
/azp run Edit: Success 🎉 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
/azp run Edit: Success 🎉 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@bijington This may finally solve it! 🤞 I've now had two successful pipeline runs with no errors. I'll change this PR from |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Third time unlucky 😭 |
|
Dang - back to the drawing board... |
Who needs tests anyway... 🤣 |
Use Collection Expressions
|
One Success! Let's try it again. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Two success! |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
3 successes! 🚀 @bijington - let's try this one more time. I'll switch to |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
VSTEST_TESTHOST_SHUTDOWN_TIMEOUT Environment VariableThe active test run was aborted. Reason: Test host process crashed
…vironment-Variable
Description of Change
This PR hopefully fixes the random crashing of the Unit Test host process in our CI/CD pipeline:
The VS Test team has added a new Environment Variable,
VSTEST_TESTHOST_SHUTDOWN_TIMEOUT, that we can leverage to extend the test runner timeout: https://github.com/microsoft/vstest/blob/02a8ba17b12757e0787b5e787b17533f21432b16/src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs#L330.This PR increases the value of
VSTEST_TESTHOST_SHUTDOWN_TIMEOUTfrom its default of 100ms to 11000ms to exceed our longest defined timeout,BaseTest.TestDuration.Long = 10000.Additional information
Source for
VSTEST_TESTHOST_SHUTDOWN_TIMEOUTinformation: microsoft/vstest#2952 (comment)This PR also fixes the crashing test process in
DrawingViewTests. The crashes were caused by injectingViewHandler.ViewMapperintoMockDrawingViewHandler.DrawingViewPropertyMapper.I also used
dotnet formatto ensure we're using CollectionExpressions in each place where we can utilize them to take advantage of their performance benefits.