Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reconnect backoff config for kafka stream to avoid repeatedly connecting to host in a tight loop. #2442

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Add reconnect backoff config for kafka stream to avoid repeatedly connecting to host in a tight loop. #2442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d07944
Add reconnect backoff config for kafka stream to avoid repeatedly con…
yma96 Jul 5, 2024
d1ba41c
Fix kafka reconnect backoff to config
yma96 Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions subsys/kafka/src/main/java/org/commonjava/indy/subsys/kafka/boot/KafkaStreamBooter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ private Properties setKafkaProps()
props.putIfAbsent( StreamsConfig.APPLICATION_ID_CONFIG, config.getGroup() );
props.putIfAbsent( StreamsConfig.BOOTSTRAP_SERVERS_CONFIG, config.getBootstrapServers() );
props.putIfAbsent( StreamsConfig.BUFFERED_RECORDS_PER_PARTITION_CONFIG, config.getRecordsPerPartition() );
props.putIfAbsent( StreamsConfig.RECONNECT_BACKOFF_MS_CONFIG, config.getReconnectBackoff() );
props.putIfAbsent( StreamsConfig.RECONNECT_BACKOFF_MAX_MS_CONFIG, config.getReconnectBackoffMax() );

logger.info( "Kafka props: {}", props );
return props;
Expand Down
30 changes: 30 additions & 0 deletions subsys/kafka/src/main/java/org/commonjava/indy/subsys/kafka/conf/KafkaConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ public class KafkaConfig

private static final Integer DEFAULT_RECORDS_PER_PARTITION = 1000;

private static final Long DEFAULT_RECONNECT_BACKOFF_MS = 60 * 1000L;

private static final Long DEFAULT_RECONNECT_BACKOFF_MAX_MS = 30 * 60 * 1000L;

private static final boolean DEFAULT_ENABLED = true;

private static final boolean DEFAULT_TRACE = false;
Expand All @@ -58,6 +62,10 @@ public class KafkaConfig

private Boolean tracing;

private Long reconnectBackoff;

private Long reconnectBackoffMax;

public KafkaConfig()
{
}
Expand Down Expand Up @@ -146,6 +154,28 @@ public void setTracing( boolean tracing )
this.tracing = tracing;
}

public Long getReconnectBackoff()
{
return reconnectBackoff == null ? DEFAULT_RECONNECT_BACKOFF_MS : reconnectBackoff;
}

@ConfigName( "kafka.reconnect.backoff" )
public void setReconnectBackoff( Long reconnectBackoff )
{
this.reconnectBackoff = reconnectBackoff;
}

public Long getReconnectBackoffMax()
{
return reconnectBackoffMax == null ? DEFAULT_RECONNECT_BACKOFF_MAX_MS : reconnectBackoffMax;
}

@ConfigName( "kafka.reconnect.backoff.max" )
public void setReconnectBackoffMax( Long reconnectBackoffMax )
{
this.reconnectBackoffMax = reconnectBackoffMax;
}

@Override
public String getDefaultConfigFileName()
{
Expand Down
Loading