Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify config #99

Merged
merged 7 commits into from
Sep 3, 2024
Merged

Simplify config #99

merged 7 commits into from
Sep 3, 2024

Conversation

ltitanb
Copy link
Collaborator

@ltitanb ltitanb commented Sep 2, 2024 •
edited
Loading

Simplify config:

  • simplify .env and make it optional
  • make metrics config optional (some parts overlap with feat: optional metrics config #98)
  • make logging config optional (defaults to info to stdout)
  • make cadivsor optional
  • add some config examples

@ltitanb ltitanb force-pushed the ltitanb/simplify-config branch from 901af69 to 79f857c Compare September 2, 2024 11:38
@ltitanb ltitanb mentioned this pull request Sep 2, 2024
Closed
@ltitanb ltitanb requested a review from fbrv September 2, 2024 16:44
@ltitanb ltitanb marked this pull request as ready for review September 2, 2024 16:44
fbrv
fbrv reviewed Sep 3, 2024
View reviewed changes
crates/cli/src/docker_init.rs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is quite some code repetition, wonder how we can simplify. We can do in later PRs

@ltitanb ltitanb merged commit fbbb8a7 into main Sep 3, 2024
4 checks passed
@ltitanb ltitanb deleted the ltitanb/simplify-config branch September 3, 2024 09:15
@ltitanb ltitanb mentioned this pull request Sep 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@David-Petrov David-Petrov David-Petrov left review comments

@fbrv fbrv fbrv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ltitanb @fbrv @David-Petrov