Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dummy /status probe in metrics' module #94

Merged
merged 3 commits into from
Aug 22, 2024
Merged

feat: add dummy /status probe in metrics' module #94

merged 3 commits into from
Aug 22, 2024

Conversation

aimxhaisse
Copy link
Contributor

No description provided.

@aimxhaisse aimxhaisse mentioned this pull request Aug 22, 2024
Closed
@aimxhaisse aimxhaisse marked this pull request as draft August 22, 2024 10:10
@aimxhaisse aimxhaisse marked this pull request as ready for review August 22, 2024 10:26
ltitanb
ltitanb requested changes Aug 22, 2024
View reviewed changes
crates/metrics/src/provider.rs Outdated Show resolved Hide resolved
crates/metrics/src/provider.rs Outdated Show resolved Hide resolved
@aimxhaisse aimxhaisse requested a review from ltitanb August 22, 2024 15:35
ltitanb
ltitanb approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@ltitanb ltitanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ltitanb ltitanb merged commit 0c12f37 into Commit-Boost:main Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltitanb ltitanb ltitanb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aimxhaisse @ltitanb