Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add draft of k8s support #92

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Conversation

aimxhaisse
Copy link
Contributor

No description provided.

@aimxhaisse aimxhaisse marked this pull request as draft August 21, 2024 16:52
@aimxhaisse aimxhaisse marked this pull request as ready for review August 22, 2024 20:23
@aimxhaisse
Copy link
Contributor Author

Runs fine on Holesky with ~30K validators behind.

@fbrv
Copy link
Contributor

fbrv commented Aug 27, 2024

Hey Seb, thanks for your contribution.
The configuration should be dynamically generated by the application CLI to create deployments for the defined modules. Can you update the code, or should I add it to my board for this sprint?

@aimxhaisse
Copy link
Contributor Author

aimxhaisse commented Aug 27, 2024

I can add it in a separate ticket if it makes sense, there are options that will be incompatible with k8s like:

#89

I think it's better to go incremental, consider k8s support a beta while iterating on it.

Your call :)

@fbrv
Copy link
Contributor

fbrv commented Aug 28, 2024

I can add it in a separate ticket if it makes sense, there are options that will be incompatible with k8s like:

#89

I think it's better to go incremental, consider k8s support a beta while iterating on it.

Your call :)

Thought about that and happy to approve this first iteration.

@fbrv fbrv merged commit 828b108 into Commit-Boost:main Aug 28, 2024
4 checks passed
@fbrv
Copy link
Contributor

fbrv commented Aug 28, 2024

#91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants