Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logs in separate containers #83

Merged
merged 4 commits into from
Aug 12, 2024
Merged

logs in separate containers #83

merged 4 commits into from
Aug 12, 2024

Conversation

fbrv
Copy link
Contributor

@fbrv fbrv commented Aug 12, 2024

Resolve issue #82 by separating each log container into its own host folder.

ltitanb
ltitanb requested changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@ltitanb ltitanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove the module id from the initialize_tracing_log since they are now in separate folders?

crates/cli/src/docker_init.rs Outdated Show resolved Hide resolved
crates/cli/src/docker_init.rs Outdated Show resolved Hide resolved
@ltitanb ltitanb self-requested a review August 12, 2024 12:25
@ltitanb ltitanb merged commit ed0d34f into main Aug 12, 2024
4 checks passed
@ltitanb ltitanb deleted the fb/logs-security branch August 12, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltitanb ltitanb ltitanb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbrv @ltitanb