Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/metrics #4

Merged
merged 9 commits into from
Jun 29, 2024
Merged

Feat/metrics #4

merged 9 commits into from
Jun 29, 2024

Conversation

mikirov
Copy link
Contributor

@mikirov mikirov commented Jun 28, 2024

This PR integrates the CB launcher of docker containers with a metrics server that reports metrics, metrics reporting SDK and docker-compose, that spawns containers for prometheus (polling the metrics server) and grafana web UI for visualization.

mikirov and others added 9 commits June 26, 2024 11:11
- main point of interest is the `crates/cli/src/lib.rs` where the metrics logic has been integrated with the dockerized launching of modules.
- merge launcher: actually populate with sample JWTs (hardcoded for now)
- `DockerMetricsCollector` needs refactor to work with a per-module JWT
- fix TODOs in `examples/da_commit`
- fix TODOs in `examples/custom_boost`
@mikirov mikirov requested a review from ltitanb June 28, 2024 19:22
Copy link
Collaborator

@ltitanb ltitanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merging and adjusting changes in main directly

@ltitanb ltitanb marked this pull request as ready for review June 29, 2024 16:03
@ltitanb ltitanb merged commit e4b5a9a into Commit-Boost:main Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants