feat(pbs): batch size config for validators registration #244
+128
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltitanb
reviewed
Jan 21, 2025
| .in_current_span(), | ||
| )); | ||
| for relay in relays.clone() { | ||
| if registrations.is_empty() { |
There was a problem hiding this comment.
is there an use case for this? i think we either avoid checking or return Ok
Comment on lines
+49
to
+65
| for batch in registrations | ||
| .chunks( | ||
| relay.config.validator_registration_batch_size.unwrap_or(registrations.len()), | ||
| ) | ||
| .map(|chunk| chunk.to_vec()) | ||
| .collect::<Vec<Vec<ValidatorRegistration>>>() | ||
| { | ||
| handles.push(tokio::spawn( | ||
| send_register_validator_with_timeout( | ||
| batch, | ||
| relay.clone(), | ||
| send_headers.clone(), | ||
| state.pbs_config().timeout_register_validator_ms, | ||
| ) | ||
| .in_current_span(), | ||
| )); | ||
| } |
There was a problem hiding this comment.
Suggested change
| for batch in registrations | |
| .chunks( | |
| relay.config.validator_registration_batch_size.unwrap_or(registrations.len()), | |
| ) | |
| .map(|chunk| chunk.to_vec()) | |
| .collect::<Vec<Vec<ValidatorRegistration>>>() | |
| { | |
| handles.push(tokio::spawn( | |
| send_register_validator_with_timeout( | |
| batch, | |
| relay.clone(), | |
| send_headers.clone(), | |
| state.pbs_config().timeout_register_validator_ms, | |
| ) | |
| .in_current_span(), | |
| )); | |
| } | |
| let registrations = registrations.clone(); | |
| if let Some(batch_size) = relay.config.validator_registration_batch_size { | |
| for batch in registrations.chunks(batch_size) { | |
| handles.push(tokio::spawn( | |
| send_register_validator_with_timeout( | |
| batch.to_vec(), | |
| relay.clone(), | |
| send_headers.clone(), | |
| state.pbs_config().timeout_register_validator_ms, | |
| ) | |
| .in_current_span(), | |
| )); | |
| } | |
| } else { | |
| handles.push(tokio::spawn( | |
| send_register_validator_with_timeout( | |
| registrations, | |
| relay.clone(), | |
| send_headers.clone(), | |
| state.pbs_config().timeout_register_validator_ms, | |
| ) | |
| .in_current_span(), | |
| )); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new configuration
validator_registration_batch_sizefor relays that splits the validators registration in batches.Logs for the following setup:
stdout:
JSON
{"timestamp":"2025-01-20T11:20:31.865510Z","level":"INFO","fields":{"ua":"bruno-runtime/1.37.0","num_registrations":1000},"target":"cb_pbs::routes::register_validator","spans":[{"req_id":"163e3dc4-c94e-4114-95f4-99dbc4adbcac","name":"register_validators"}]} {"timestamp":"2025-01-20T11:20:31.871220Z","level":"DEBUG","fields":{"message":"registration successful","code":"200","latency":"5.0075ms"},"target":"cb_pbs::mev_boost::register_validator","spans":[{"req_id":"163e3dc4-c94e-4114-95f4-99dbc4adbcac","name":"register_validators"},{"relay_id":"relay-4","retry":0,"name":"handler"}]} {"timestamp":"2025-01-20T11:20:31.871925Z","level":"DEBUG","fields":{"message":"registration successful","code":"200","latency":"5.723209ms"},"target":"cb_pbs::mev_boost::register_validator","spans":[{"req_id":"163e3dc4-c94e-4114-95f4-99dbc4adbcac","name":"register_validators"},{"relay_id":"relay-5","retry":0,"name":"handler"}]} {"timestamp":"2025-01-20T11:20:31.872362Z","level":"DEBUG","fields":{"message":"registration successful","code":"200","latency":"6.195667ms"},"target":"cb_pbs::mev_boost::register_validator","spans":[{"req_id":"163e3dc4-c94e-4114-95f4-99dbc4adbcac","name":"register_validators"},{"relay_id":"relay-3","retry":0,"name":"handler"}]} {"timestamp":"2025-01-20T11:20:31.873467Z","level":"DEBUG","fields":{"message":"registration successful","code":"200","latency":"5.093ms"},"target":"cb_pbs::mev_boost::register_validator","spans":[{"req_id":"163e3dc4-c94e-4114-95f4-99dbc4adbcac","name":"register_validators"},{"relay_id":"relay-5","retry":0,"name":"handler"}]} {"timestamp":"2025-01-20T11:20:31.873544Z","level":"DEBUG","fields":{"message":"registration successful","code":"200","latency":"7.519541ms"},"target":"cb_pbs::mev_boost::register_validator","spans":[{"req_id":"163e3dc4-c94e-4114-95f4-99dbc4adbcac","name":"register_validators"},{"relay_id":"relay-5","retry":0,"name":"handler"}]} {"timestamp":"2025-01-20T11:20:31.873807Z","level":"DEBUG","fields":{"message":"registration successful","code":"200","latency":"7.673167ms"},"target":"cb_pbs::mev_boost::register_validator","spans":[{"req_id":"163e3dc4-c94e-4114-95f4-99dbc4adbcac","name":"register_validators"},{"relay_id":"relay-3","retry":0,"name":"handler"}]} {"timestamp":"2025-01-20T11:20:31.874351Z","level":"DEBUG","fields":{"message":"registration successful","code":"200","latency":"8.255709ms"},"target":"cb_pbs::mev_boost::register_validator","spans":[{"req_id":"163e3dc4-c94e-4114-95f4-99dbc4adbcac","name":"register_validators"},{"relay_id":"relay-5","retry":0,"name":"handler"}]} {"timestamp":"2025-01-20T11:20:31.874755Z","level":"DEBUG","fields":{"message":"registration successful","code":"200","latency":"8.664583ms"},"target":"cb_pbs::mev_boost::register_validator","spans":[{"req_id":"163e3dc4-c94e-4114-95f4-99dbc4adbcac","name":"register_validators"},{"relay_id":"relay-3","retry":0,"name":"handler"}]} {"timestamp":"2025-01-20T11:20:31.874875Z","level":"DEBUG","fields":{"message":"registration successful","code":"200","latency":"8.778792ms"},"target":"cb_pbs::mev_boost::register_validator","spans":[{"req_id":"163e3dc4-c94e-4114-95f4-99dbc4adbcac","name":"register_validators"},{"relay_id":"relay-2","retry":0,"name":"handler"}]} {"timestamp":"2025-01-20T11:20:31.874984Z","level":"DEBUG","fields":{"message":"registration successful","code":"200","latency":"9.0115ms"},"target":"cb_pbs::mev_boost::register_validator","spans":[{"req_id":"163e3dc4-c94e-4114-95f4-99dbc4adbcac","name":"register_validators"},{"relay_id":"relay-1","retry":0,"name":"handler"}]} {"timestamp":"2025-01-20T11:20:31.875113Z","level":"DEBUG","fields":{"message":"registration successful","code":"200","latency":"6.876042ms"},"target":"cb_pbs::mev_boost::register_validator","spans":[{"req_id":"163e3dc4-c94e-4114-95f4-99dbc4adbcac","name":"register_validators"},{"relay_id":"relay-4","retry":0,"name":"handler"}]} {"timestamp":"2025-01-20T11:20:31.875141Z","level":"DEBUG","fields":{"message":"registration successful","code":"200","latency":"6.557584ms"},"target":"cb_pbs::mev_boost::register_validator","spans":[{"req_id":"163e3dc4-c94e-4114-95f4-99dbc4adbcac","name":"register_validators"},{"relay_id":"relay-2","retry":0,"name":"handler"}]} {"timestamp":"2025-01-20T11:20:31.875315Z","level":"INFO","fields":{"message":"register validator successful"},"target":"cb_pbs::routes::register_validator","spans":[{"req_id":"163e3dc4-c94e-4114-95f4-99dbc4adbcac","name":"register_validators"}]}Close #226